[SPARK-25653][TEST] Add tag ExtendedHiveTest for HiveSparkSubmitSuite #22642
Conversation
|
@gengliangwang I have a question. What happens when we place this tag ? It is skipped on regular runs ? |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (pending Jenkins).
|
cc @gatorsmile for final sign-off since this is a test coverage. |
|
@dilipbiswal . It's not skipped in the regular Jenkins run until now. As you know, those test will be skipped when we give that explicitly. For example, |
|
@dongjoon-hyun Ah.. got it.. thanks a lot. |
|
BTW, @gengliangwang . Please create a different JIRA issue for this. This doesn't resolve SPARK-25613 and SPARK-25614. If we close them with this, we will not improve those test cases eventually. cc @gatorsmile |
|
Test build #96998 has finished for PR 22642 at commit
|
gengliangwang
changed the title
|
@dongjoon-hyun thanks, I have created new Jira ticket: https://issues.apache.org/jira/browse/SPARK-25653 |
|
Thank you, @gengliangwang ! |
| /** | ||
| * This suite tests spark-submit with applications using HiveContext. | ||
| */ | ||
| @ExtendedHiveTest |
There was a problem hiding this comment.
With this tag, the test suite will still run if we do a code change in sql/hive. Right? cc @cloud-fan @vanzin
There was a problem hiding this comment.
That was the original intent of the tag. I believe originally it ran whenever there was a change to any of the SQL code, but not sure if the module mappings have been updated in the meantime.
|
LGTM Thanks! Merged to master. |
## What changes were proposed in this pull request? The total run time of `HiveSparkSubmitSuite` is about 10 minutes. While the related code is stable, add tag `ExtendedHiveTest` for it. ## How was this patch tested? Unit test. Closes apache#22642 from gengliangwang/addTagForHiveSparkSubmitSuite. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: gatorsmile <[email protected]>
6 participants
What changes were proposed in this pull request?
The total run time of
HiveSparkSubmitSuiteis about 10 minutes.While the related code is stable, add tag
ExtendedHiveTestfor it.How was this patch tested?
Unit test.