[SPARK-25321][ML] Revert SPARK-14681 to avoid API breaking change #22618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? Revert SPARK-14681 to avoid API breaking change. PR [SPARK-14681] will break mleap. ## How was this patch tested? N/A Closes apache#22492 from WeichenXu123/revert_tree_change. Authored-by: WeichenXu <[email protected]> Signed-off-by: Xiangrui Meng <[email protected]>
|
Test build #96874 has finished for PR 22618 at commit
|
Contributor
|
LGTM. Thanks! |
Member
|
Retest this please. |
dongjoon-hyun
approved these changes
Oct 6, 2018
Member
There was a problem hiding this comment.
+1, LGTM.
I also confirm that this is a clean cherry-pick from branch-2.4 to master.
For the discussion on backport, please see #22492 .
|
Test build #97061 has finished for PR 22618 at commit
|
Member
|
Retest this please. |
|
Test build #97070 has finished for PR 22618 at commit
|
Member
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This is the same as apache#22492 but for master branch. Revert SPARK-14681 to avoid API breaking changes. cc: WeichenXu123 ## How was this patch tested? Existing unit tests. Closes apache#22618 from mengxr/SPARK-25321.master. Authored-by: WeichenXu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the same as #22492 but for master branch. Revert SPARK-14681 to avoid API breaking changes.
cc: @WeichenXu123
How was this patch tested?
Existing unit tests.