-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25321][ML] Revert SPARK-14681 to avoid API breaking change #22492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ecision tree nodes" This reverts commit 252468a.
|
Since this changes public API, shall we also revert it from master? |
|
Test build #96352 has finished for PR 22492 at commit
|
|
@mengxr Should this be put into master ? |
|
We can keep it in master if the next release is 3.0. |
## What changes were proposed in this pull request? Revert SPARK-14681 to avoid API breaking change. PR [SPARK-14681] will break mleap. ## How was this patch tested? N/A Closes #22492 from WeichenXu123/revert_tree_change. Authored-by: WeichenXu <[email protected]> Signed-off-by: Xiangrui Meng <[email protected]>
|
LGTM. Merged into branch-2.4. @WeichenXu123 Next time please create dedicated JIRAs for each QA task PR. Thanks! |
|
@WeichenXu123 Please close this PR manually. Thanks! |
|
The next version is very likely to be 2.5.0... |
## What changes were proposed in this pull request? Revert SPARK-14681 to avoid API breaking change. PR [SPARK-14681] will break mleap. ## How was this patch tested? N/A Closes apache#22492 from WeichenXu123/revert_tree_change. Authored-by: WeichenXu <[email protected]> Signed-off-by: Xiangrui Meng <[email protected]>
|
@WeichenXu123 @cloud-fan I made #22618 to revert the change in master. |
|
May I ask a question, @mengxr ? The master becomes 3.0 today by @gatorsmile 's PR and I saw the following your comment here.
Is there any new reason to change the decision? |
|
@cloud-fan said above the next version is very likely to be 2.5.0 instead of 3.0. Well the next version number is not fully discussed yet. For that reason, I think we should revert the changes in master as well. After that we should check if the feature itself can be added without introducing breaking changes. |
## What changes were proposed in this pull request? This is the same as #22492 but for master branch. Revert SPARK-14681 to avoid API breaking changes. cc: WeichenXu123 ## How was this patch tested? Existing unit tests. Closes #22618 from mengxr/SPARK-25321.master. Authored-by: WeichenXu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
## What changes were proposed in this pull request? This is the same as apache#22492 but for master branch. Revert SPARK-14681 to avoid API breaking changes. cc: WeichenXu123 ## How was this patch tested? Existing unit tests. Closes apache#22618 from mengxr/SPARK-25321.master. Authored-by: WeichenXu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
Revert SPARK-14681 to avoid API breaking change. PR [SPARK-14681] will break mleap.
How was this patch tested?
N/A