[SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12. #22059
Closed
kiszk wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12. #22059kiszk wants to merge 1 commit intoapache:masterfrom
kiszk wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #94511 has finished for PR 22059 at commit
|
Member
Author
|
retest this please |
|
Test build #94520 has finished for PR 22059 at commit
|
Member
Author
srowen
approved these changes
Aug 10, 2018
Member
srowen
left a comment
There was a problem hiding this comment.
BTW I was working on compile errors too -- see srowen@5ea659f . You might see about picking up those into one PR rather than many. In particular I am interested to fix the ExprValue compile warning.
Member
|
Yea, It would be better to put those error into fewer PRs if possible. |
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR avoid the following compilation error using sbt in Scala-2.12.
How was this patch tested?
Existing UTs