Skip to content

[SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12. #22059

Closed
kiszk wants to merge 1 commit intoapache:masterfrom
kiszk:SPARK-25036d
Closed

[SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12. #22059
kiszk wants to merge 1 commit intoapache:masterfrom
kiszk:SPARK-25036d

Conversation

@kiszk
Copy link
Copy Markdown
Member

@kiszk kiszk commented Aug 9, 2018

What changes were proposed in this pull request?

This PR avoid the following compilation error using sbt in Scala-2.12.

[error] [warn] /home/ishizaki/Spark/PR/scala212/spark/mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala:410: discarding unmoored doc comment
[error] [warn]     /**
[error] [warn] 
[error] [warn] /home/ishizaki/Spark/PR/scala212/spark/mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala:441: discarding unmoored doc comment
[error] [warn]     /**
[error] [warn] 
...
[error] [warn] /home/ishizaki/Spark/PR/scala212/spark/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:440: discarding unmoored doc comment
[error] [warn]     /**
[error] [warn] 

How was this patch tested?

Existing UTs

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 9, 2018

Test build #94511 has finished for PR 22059 at commit 70ec11e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Copy Markdown
Member Author

kiszk commented Aug 9, 2018

retest this please

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 9, 2018

Test build #94520 has finished for PR 22059 at commit 70ec11e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Copy Markdown
Member Author

kiszk commented Aug 10, 2018

cc @srowen @ueshin @HyukjinKwon

Copy link
Copy Markdown
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I was working on compile errors too -- see srowen@5ea659f . You might see about picking up those into one PR rather than many. In particular I am interested to fix the ExprValue compile warning.

@HyukjinKwon
Copy link
Copy Markdown
Member

Yea, It would be better to put those error into fewer PRs if possible.

@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 10, 2018

Merged to master

@asfgit asfgit closed this in 132bcce Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants