[SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exhaustive in Scala-2.12.#22058
Closed
kiszk wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exhaustive in Scala-2.12.#22058kiszk wants to merge 3 commits intoapache:masterfrom
kiszk wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
Member
|
I see, did you run sbt one more time after this to see if there were more? would be good to address all of the ones worth changing in this pass. |
|
Test build #94509 has finished for PR 22058 at commit
|
srowen
reviewed
Aug 9, 2018
| case ("silhouette", "cosine") => | ||
| CosineSilhouette.computeSilhouetteScore(df, $(predictionCol), $(featuresCol)) | ||
| case (mn, dm) => | ||
| throw new IllegalArgumentException(s"($mn, $dm) is not matched in evaluate") |
Member
There was a problem hiding this comment.
This is OK, but doesn't really add much beyond what the MatchError would have said. Worth a message like "No support for metric $mn, distance $dm"?
Member
Author
|
Test build #94517 has finished for PR 22058 at commit
|
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr of #22014 and #22039
We still have some more compilation errors in mllib with scala-2.12 with sbt:
How was this patch tested?
Existing UTs