[SPARK-23566][Minor][Doc] Argument name mismatch fixed #20716
Conversation
Argument name mismatch fixed. `col` changed to `new` in doc string to match the argument list.
|
ok to test |
|
It's fine. Can you double check if there are same instances in this file or other files? |
|
Test build #87888 has finished for PR 20716 at commit
|
|
@HyukjinKwon Sure, shall do. |
|
Test build #87932 has finished for PR 20716 at commit
|
|
Test build #87934 has finished for PR 20716 at commit
|
removed trailing white space - style fix
|
Test build #87935 has finished for PR 20716 at commit
|
|
@HyukjinKwon Found couple more, have updated the same. |
| If it is a Column, it will be used as the first partitioning column. If not specified, | ||
| the default number of partitions is used. | ||
| :param numPartitions: | ||
| can be an int to specify the target number of partitions or a Column. |
There was a problem hiding this comment.
I think it's fine to:
:param numPartitions: can be an int to specify the target number of partitions or a Column.
If it is a Column, it will be used as the first partitioning column. If not specified,
There was a problem hiding this comment.
Cool, was maintaining consistency with other :param on page.
python/pyspark/sql/dataframe.py
Outdated
| def alias(self, alias): | ||
| """Returns a new :class:`DataFrame` with an alias set. | ||
| :param alias: string, alias names to be set for the DataFrame. |
There was a problem hiding this comment.
alias names -> an alias name
|
BTW, it doesn't need a JIRA for minor fixes. Let's avoid this next time :). |
grammar
|
Test build #87936 has finished for PR 20716 at commit
|
|
Do check @gatorsmile |
|
Merged to master Sorry, I pushed this before seeing the comment above. Please do a check or followup if required or requested. |
Argument name mismatch fixed. ## What changes were proposed in this pull request? `col` changed to `new` in doc string to match the argument list. Patch file added: https://issues.apache.org/jira/browse/SPARK-23566 Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Anirudh <[email protected]> Closes apache#20716 from animenon/master.
|
@HyukjinKwon Its minor, so may not be required. Had tagged Gator just for a check. |
3 participants
Argument name mismatch fixed.
What changes were proposed in this pull request?
colchanged tonewin doc string to match the argument list.Patch file added: https://issues.apache.org/jira/browse/SPARK-23566
Please review http://spark.apache.org/contributing.html before opening a pull request.