Skip to content

[SPARK-23434][SQL] Spark should not warn metadata directory for a HDFS file path #20616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[SPARK-23434][SQL] Spark should not warn metadata directory for a HDFS file path #20616

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a14ff69
[SPARK-23434][SQL] Spark should not warn `metadata directory` for a H…
dongjoon-hyun Feb 15, 2018
a7432b7
Address comment
dongjoon-hyun Feb 20, 2018
27188e7
update more
dongjoon-hyun Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,13 @@ object FileStreamSink extends Logging {
try {
val hdfsPath = new Path(singlePath)
val fs = hdfsPath.getFileSystem(hadoopConf)
val metadataPath = new Path(hdfsPath, metadataDir)
val res = fs.exists(metadataPath)
res
if (fs.isDirectory(hdfsPath)) {
val metadataPath = new Path(hdfsPath, metadataDir)
val res = fs.exists(metadataPath)
res
Copy link
Contributor

@cloud-fan cloud-fan Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just fs.exists(new Path(hdfsPath, metadataDir))

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

} else {
false
}
} catch {
case NonFatal(e) =>
logWarning(s"Error while looking for metadata directory.")
Expand Down