[SPARK-23434][SQL] Spark should not warn metadata directory for a HDFS file path
#20616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #87469 has finished for PR 20616 at commit
|
Member
Author
|
Retest this please. |
|
Test build #87476 has finished for PR 20616 at commit
|
Member
Author
|
Hi, @cloud-fan and @gatorsmile . |
Contributor
|
LGTM, cc @zsxwing |
Member
Author
|
Thank you for review, @cloud-fan . |
cloud-fan
reviewed
Feb 20, 2018
| if (fs.isDirectory(hdfsPath)) { | ||
| val metadataPath = new Path(hdfsPath, metadataDir) | ||
| val res = fs.exists(metadataPath) | ||
| res |
Contributor
There was a problem hiding this comment.
nit: just fs.exists(new Path(hdfsPath, metadataDir))
|
Test build #87550 has finished for PR 20616 at commit
|
Member
Author
|
Could you review this, @zsxwing and @gatorsmile ? |
Member
Author
|
With more manual tests, I observed that the original situation happens on only kerberized environments. I updated PR/JIRA description. |
Member
|
@dongjoon-hyun could you also post the error happening in kerberized environments? |
Member
Author
|
The warning error messages in kerberized environments are the one in PR/JIRA description. |
Member
|
@dongjoon-hyun I meant the stack trace thrown from |
Member
Author
|
Here, it is. It's |
Member
|
LGTM. Merging to master. Thanks! |
Member
Author
|
Thank you, @zsxwing and @cloud-fan . |
Member
Author
|
Hi, @cloud-fan and @zsxwing . |
Contributor
|
no objection from my side. |
Member
Author
|
Thank you, @cloud-fan . |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…DFS file path
In a kerberized cluster, when Spark reads a file path (e.g. `people.json`), it warns with a wrong warning message during looking up `people.json/_spark_metadata`. The root cause of this situation is the difference between `LocalFileSystem` and `DistributedFileSystem`. `LocalFileSystem.exists()` returns `false`, but `DistributedFileSystem.exists` raises `org.apache.hadoop.security.AccessControlException`.
```scala
scala> spark.version
res0: String = 2.4.0-SNAPSHOT
scala> spark.read.json("file:///usr/hdp/current/spark-client/examples/src/main/resources/people.json").show
+----+-------+
| age| name|
+----+-------+
|null|Michael|
| 30| Andy|
| 19| Justin|
+----+-------+
scala> spark.read.json("hdfs:///tmp/people.json")
18/02/15 05:00:48 WARN streaming.FileStreamSink: Error while looking for metadata directory.
18/02/15 05:00:48 WARN streaming.FileStreamSink: Error while looking for metadata directory.
```
After this PR,
```scala
scala> spark.read.json("hdfs:///tmp/people.json").show
+----+-------+
| age| name|
+----+-------+
|null|Michael|
| 30| Andy|
| 19| Justin|
+----+-------+
```
Manual.
Author: Dongjoon Hyun <[email protected]>
Closes apache#20616 from dongjoon-hyun/SPARK-23434.
Change-Id: I45931d7132c5cb9acd6cf095b9af6cb87a3f0c33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In a kerberized cluster, when Spark reads a file path (e.g.
people.json), it warns with a wrong warning message during looking uppeople.json/_spark_metadata. The root cause of this situation is the difference betweenLocalFileSystemandDistributedFileSystem.LocalFileSystem.exists()returnsfalse, butDistributedFileSystem.existsraisesorg.apache.hadoop.security.AccessControlException.After this PR,
How was this patch tested?
Manual.