Changing JDBC relation to better process quotes #20370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
reviewed
Jan 23, 2018
| val stride: Long = upperBound / numPartitions - lowerBound / numPartitions | ||
| val column = partitioning.column | ||
| val dialect = JdbcDialects.get(jdbcOptions.url) | ||
| val column = dialect.quoteIdentifier(partitioning.column) |
Member
There was a problem hiding this comment.
We should do it in class JDBCOptions. To avoid breaking the behavior, we should eat the quotes if users manually specify them.
Member
There was a problem hiding this comment.
We also need to add a test case in PostgresIntegrationSuite
Member
|
@conorbmurphy Could you create a JIRA and follow the instruction to make a contribution? |
Author
|
Will do! |
Member
|
Hi, @conorbmurphy . |
Member
|
ping @conorbmurphy |
Member
|
ping @conorbmurphy Are you still working on this? Otherwise, maybe @maropu can continue the work and finish it? |
Member
|
ya, I can take it over. |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The way JDBC writes currently work, they do not properly account for mixed case column names. Instead, the user has to use quotes on each column name. This change avoids that.
How was this patch tested?
Manual tests and working with @dougbateman and @gatorsmile
Please review http://spark.apache.org/contributing.html before opening a pull request.