Skip to content

Changing JDBC relation to better process quotes #20370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conorbmurphy wants to merge 1 commit into from
Closed

Changing JDBC relation to better process quotes #20370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ private[sql] object JDBCRelation extends Logging {
// Overflow and silliness can happen if you subtract then divide.
// Here we get a little roundoff, but that's (hopefully) OK.
val stride: Long = upperBound / numPartitions - lowerBound / numPartitions
val column = partitioning.column
val dialect = JdbcDialects.get(jdbcOptions.url)
val column = dialect.quoteIdentifier(partitioning.column)
Copy link
Member

@gatorsmile gatorsmile Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do it in class JDBCOptions. To avoid breaking the behavior, we should eat the quotes if users manually specify them.

Copy link
Member

@gatorsmile gatorsmile Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add a test case in PostgresIntegrationSuite

var i: Int = 0
var currentValue: Long = lowerBound
val ans = new ArrayBuffer[Partition]()
Expand Down