Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,150 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.spark.ml.optim.aggregator

import org.apache.spark.broadcast.Broadcast
import org.apache.spark.ml.feature.Instance
import org.apache.spark.ml.linalg.Vector

/**
* HuberAggregator computes the gradient and loss for a huber loss function,
* as used in robust regression for samples in sparse or dense vector in an online fashion.
*
* The huber loss function based on:
* <a href="http://statweb.stanford.edu/~owen/reports/hhu.pdf">Art B. Owen (2006),
* A robust hybrid of lasso and ridge regression</a>.
*
* Two HuberAggregator can be merged together to have a summary of loss and gradient of
* the corresponding joint dataset.
*
* The huber loss function is given by
*
* <blockquote>
* $$
* \begin{align}
* \min_{w, \sigma}\frac{1}{2n}{\sum_{i=1}^n\left(\sigma +
* H_m\left(\frac{X_{i}w - y_{i}}{\sigma}\right)\sigma\right) + \frac{1}{2}\lambda {||w||_2}^2}
* \end{align}
* $$
* </blockquote>
*
* where
*
* <blockquote>
* $$
* \begin{align}
* H_m(z) = \begin{cases}
* z^2, & \text {if } |z| &lt; \epsilon, \\
* 2\epsilon|z| - \epsilon^2, & \text{otherwise}
* \end{cases}
* \end{align}
* $$
* </blockquote>
*
* It is advised to set the parameter $\epsilon$ to 1.35 to achieve 95% statistical efficiency
* for normally distributed data. Please refer to chapter 2 of
* <a href="http://statweb.stanford.edu/~owen/reports/hhu.pdf">
* A robust hybrid of lasso and ridge regression</a> for more detail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide reference here but not in epsilon param in LinearRegression, IMO since this is a internal method, maybe the reference is more useful in LinearRegression ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

*
* @param fitIntercept Whether to fit an intercept term.
* @param epsilon The shape parameter to control the amount of robustness.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document epsilon param more clearly, including the comment that it matches sklearn and is "M" from the paper.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have documented them at the definition of epsilon param in LinearRegression, as there should be public and here is for internal use only.

* @param bcFeaturesStd The broadcast standard deviation values of the features.
* @param bcParameters including three parts: the regression coefficients corresponding
* to the features, the intercept (if fitIntercept is ture)
* and the scale parameter (sigma).
*/
private[ml] class HuberAggregator(
fitIntercept: Boolean,
epsilon: Double,
bcFeaturesStd: Broadcast[Array[Double]])(bcParameters: Broadcast[Vector])
extends DifferentiableLossAggregator[Instance, HuberAggregator] {

protected override val dim: Int = bcParameters.value.size
private val numFeatures: Int = if (fitIntercept) dim - 2 else dim - 1
private val sigma: Double = bcParameters.value(dim - 1)
private val intercept: Double = if (fitIntercept) {
bcParameters.value(dim - 2)
} else {
0.0
}

/**
* Add a new training instance to this HuberAggregator, and update the loss and gradient
* of the objective function.
*
* @param instance The instance of data point to be added.
* @return This HuberAggregator object.
*/
def add(instance: Instance): HuberAggregator = {
instance match { case Instance(label, weight, features) =>
require(numFeatures == features.size, s"Dimensions mismatch when adding new sample." +
s" Expecting $numFeatures but got ${features.size}.")
require(weight >= 0.0, s"instance weight, $weight has to be >= 0.0")

if (weight == 0.0) return this
val localFeaturesStd = bcFeaturesStd.value
val localCoefficients = bcParameters.value.toArray.slice(0, numFeatures)
val localGradientSumArray = gradientSumArray

val margin = {
var sum = 0.0
features.foreachActive { (index, value) =>
if (localFeaturesStd(index) != 0.0 && value != 0.0) {
sum += localCoefficients(index) * (value / localFeaturesStd(index))
}
}
if (fitIntercept) sum += intercept
sum
}
val linearLoss = label - margin

if (math.abs(linearLoss) <= sigma * epsilon) {
lossSum += 0.5 * weight * (sigma + math.pow(linearLoss, 2.0) / sigma)
val linearLossDivSigma = linearLoss / sigma

features.foreachActive { (index, value) =>
if (localFeaturesStd(index) != 0.0 && value != 0.0) {
localGradientSumArray(index) +=
-1.0 * weight * linearLossDivSigma * (value / localFeaturesStd(index))
}
}
if (fitIntercept) {
localGradientSumArray(dim - 2) += -1.0 * weight * linearLossDivSigma
}
localGradientSumArray(dim - 1) += 0.5 * weight * (1.0 - math.pow(linearLossDivSigma, 2.0))
} else {
val sign = if (linearLoss >= 0) -1.0 else 1.0
lossSum += 0.5 * weight *
(sigma + 2.0 * epsilon * math.abs(linearLoss) - sigma * epsilon * epsilon)

features.foreachActive { (index, value) =>
if (localFeaturesStd(index) != 0.0 && value != 0.0) {
localGradientSumArray(index) +=
weight * sign * epsilon * (value / localFeaturesStd(index))
}
}
if (fitIntercept) {
localGradientSumArray(dim - 2) += weight * sign * epsilon
}
localGradientSumArray(dim - 1) += 0.5 * weight * (1.0 - epsilon * epsilon)
}

weightSum += weight
this
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ private[shared] object SharedParamsCodeGen {
"during tuning. If set to false, then only the single best sub-model will be available " +
"after fitting. If set to true, then all sub-models will be available. Warning: For " +
"large models, collecting all sub-models can cause OOMs on the Spark driver",
Some("false"), isExpertParam = true)
Some("false"), isExpertParam = true),
ParamDesc[String]("loss", "the loss function to be optimized", finalFields = false)
)

val code = genSharedParams(params)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -487,4 +487,21 @@ trait HasCollectSubModels extends Params {
/** @group expertGetParam */
final def getCollectSubModels: Boolean = $(collectSubModels)
}

/**
* Trait for shared param loss. This trait may be changed or
* removed between minor versions.
*/
@DeveloperApi
trait HasLoss extends Params {

/**
* Param for the loss function to be optimized.
* @group param
*/
val loss: Param[String] = new Param[String](this, "loss", "the loss function to be optimized")

/** @group getParam */
final def getLoss: String = $(loss)
}
// scalastyle:on
Loading