[SPARK-21516][SQL][Test] Overriding afterEach() in DatasetCacheSuite must call super.afterEach()

[kiszk]

What changes were proposed in this pull request?

This PR ensures to call super.afterEach() in overriding afterEach() method in DatasetCacheSuite. When we override afterEach() method in Testsuite, we have to call super.afterEach().

This is a follow-up of #18719 and SPARK-21512.

How was this patch tested?

Used the existing test suite

[cloud-fan]

LGTM

[SparkQA]

Test build #79899 has finished for PR 18721 at commit 0e4d057.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

retest this please

[srowen]

@kiszk while you're here, looks like HiveExternalCatalogBackwardCompatibilitySuite, ContainerPlacementStrategySuite, SparkSessionBuilderSuite, TextSocketStreamSuite need this fix too.

[kiszk]

@srowen good catch. I will work for that.
Another question is whether we should do this cleanup at SharedSQLContext.afterEach().
cc @gatorsmile @cloud-fan

[SparkQA]

Test build #79900 has finished for PR 18721 at commit 0e4d057.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

yea if many tests suite need the same fix, we can put it in SharedSQLContext.afterEach()

[SparkQA]

Test build #79903 has finished for PR 18721 at commit 2ac2798.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

sorry to be nit-pick, but seems we can just do

super.afterEach()
// Clear all persistent datasets after each test
spark.sharedState.cacheManager.clearCache()

[kiszk]

I see. done

[SparkQA]

Test build #79912 has finished for PR 18721 at commit bd6c2ad.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

thanks, merging to master!