[SPARK-21512][SQL][TEST] DatasetCacheSuite needs to execute unpersistent after executing peristent #18719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gatorsmile could you please review this? |
|
Test build #79883 has finished for PR 18719 at commit
|
Member
Author
|
cc @cloud-fan |
Contributor
|
shall we add a |
Member
Author
|
Good suggestion, make sense. done. |
|
Test build #79889 has finished for PR 18719 at commit
|
Member
|
Thanks! Merging to master. |
gatorsmile
reviewed
Jul 23, 2017
|
|
||
| // Clear all persistent datasets after each test | ||
| override def afterEach(): Unit = { | ||
| spark.sharedState.cacheManager.clearCache() |
Member
There was a problem hiding this comment.
try {
// Clear all persistent datasets after each test
spark.sharedState.cacheManager.clearCache()
} finally {
super.afterEach()
}
Contributor
There was a problem hiding this comment.
+1, ideally we should always call super.afterEach, @kiszk can you send a follow-up PR? thx
Member
Author
|
good catch, i will create a follow-up PR today. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jul 25, 2017
…must call super.afterEach() ## What changes were proposed in this pull request? This PR ensures to call `super.afterEach()` in overriding `afterEach()` method in `DatasetCacheSuite`. When we override `afterEach()` method in Testsuite, we have to call `super.afterEach()`. This is a follow-up of apache#18719 and SPARK-21512. ## How was this patch tested? Used the existing test suite Author: Kazuaki Ishizaki <[email protected]> Closes apache#18721 from kiszk/SPARK-21516.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR avoids to reuse unpersistent dataset among test cases by making dataset unpersistent at the end of each test case.
In
DatasetCacheSuite, the test case"get storage level"does not make dataset unpersisit after make the dataset persisitent. The same dataset will be made persistent by the test case"persist and then rebind right encoder when join 2 datasets"Thus, we run these test cases, the second case does not perform to make dataset persistent. This is because inWhen we run only the second case, it performs to make dataset persistent. It is not good to change behavior of the second test suite. The first test case should correctly make dataset unpersistent.
After this PR, these messages do not appear
How was this patch tested?
Used the existing test