Skip to content

Conversation

@windpiger
Copy link
Contributor

@windpiger windpiger commented Feb 21, 2017

What changes were proposed in this pull request?

In SPARK-19669 change the sessionState access privileges from private to public, this lead to the compile failed in TestSQLContext

this pr is a hotfix for this.

How was this patch tested?

N/A

@windpiger windpiger changed the title [SPARK-19669][HOTFIX][SQL] sessionState access privileges compiled in TestSQLContext [SPARK-19669][HOTFIX][SQL] sessionState access privileges compiled failed in TestSQLContext Feb 21, 2017
@zzcclp
Copy link
Contributor

zzcclp commented Feb 21, 2017

I meet the same error in branch master :
overriding lazy value sessionState in class SparkSession of type org.apache.spark.sql.internal.SessionState; lazy value sessionState has weaker access privileges; it should be public

@gatorsmile
Copy link
Member

gatorsmile commented Feb 21, 2017

LGTM. Just checked the console output. It already passes the build.

Thanks! Merging to master.

@asfgit asfgit closed this in 73f0655 Feb 21, 2017
@SparkQA
Copy link

SparkQA commented Feb 21, 2017

Test build #73192 has finished for PR 17008 at commit 99db6cf.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@windpiger
Copy link
Contributor Author

passed localy, retest this please

Yunni pushed a commit to Yunni/spark that referenced this pull request Feb 27, 2017
…iled in TestSQLContext

## What changes were proposed in this pull request?

In [SPARK-19669](apache@0733a54) change the sessionState access privileges from private to public, this lead to the compile failed in TestSQLContext

this pr is a hotfix for this.

## How was this patch tested?
N/A

Author: windpiger <[email protected]>

Closes apache#17008 from windpiger/hotfixcompile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants