[SPARK-19669][SQL] Open up visibility for sharedState, sessionState, and a few other functions #17002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and a few other functions
gatorsmile
reviewed
Feb 20, 2017
| */ | ||
| @InterfaceStability.Unstable | ||
| @transient | ||
| private[sql] lazy val sessionState: SessionState = { |
Member
There was a problem hiding this comment.
Like sharedState, also remove private[sql]?
Member
|
LGTM |
|
Test build #73181 has finished for PR 17002 at commit
|
|
Test build #73176 has finished for PR 17002 at commit
|
Member
|
Thanks! Merging to master. |
Contributor
|
@gatorsmile @rxin |
Member
|
uh... I missed that. |
Contributor
Author
|
Yea @gatorsmile be careful in the future and check the commit hash. |
Member
|
Yeah. Will be more careful in the future. Sorry for that. |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…and a few other functions ## What changes were proposed in this pull request? To ease debugging, most of Spark SQL internals have public level visibility. Two of the most important internal states, sharedState and sessionState, however, are package private. It would make more sense to open these up as well with clear documentation that they are internal. In addition, users currently have way to set active/default SparkSession, but no way to actually get them back. We should open those up as well. ## How was this patch tested? N/A - only visibility change. Author: Reynold Xin <[email protected]> Closes apache#17002 from rxin/SPARK-19669.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To ease debugging, most of Spark SQL internals have public level visibility. Two of the most important internal states, sharedState and sessionState, however, are package private. It would make more sense to open these up as well with clear documentation that they are internal.
In addition, users currently have way to set active/default SparkSession, but no way to actually get them back. We should open those up as well.
How was this patch tested?
N/A - only visibility change.