Skip to content

[SPARK-18167] [SQL] Add debug code for SQLQuerySuite flakiness when metastore partition pruning is enabled #15676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericl wants to merge 5 commits into from
Closed

[SPARK-18167] [SQL] Add debug code for SQLQuerySuite flakiness when metastore partition pruning is enabled #15676

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d62dbd
Fri Oct 28 15:43:06 PDT 2016
ericl Oct 28, 2016
28f6445
Fri Oct 28 15:48:00 PDT 2016
ericl Oct 28, 2016
3d7b7f1
Fri Oct 28 15:48:32 PDT 2016
ericl Oct 28, 2016
b2bbcc8
Fri Oct 28 15:48:38 PDT 2016
ericl Oct 28, 2016
98a35c6
Fri Oct 28 15:49:10 PDT 2016
ericl Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import java.util.{ArrayList => JArrayList, List => JList, Map => JMap, Set => JS
import java.util.concurrent.TimeUnit

import scala.collection.JavaConverters._
import scala.util.Try
import scala.util.control.NonFatal

import org.apache.hadoop.fs.{FileSystem, Path}
Expand Down Expand Up @@ -585,7 +586,19 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
getAllPartitionsMethod.invoke(hive, table).asInstanceOf[JSet[Partition]]
} else {
logDebug(s"Hive metastore filter is '$filter'.")
getPartitionsByFilterMethod.invoke(hive, table, filter).asInstanceOf[JArrayList[Partition]]
try {
getPartitionsByFilterMethod.invoke(hive, table, filter)
.asInstanceOf[JArrayList[Partition]]
} catch {
case e: InvocationTargetException =>
// SPARK-18167 retry to investigate the flaky test. This should be reverted before
// the release is cut.
val retry = Try(getPartitionsByFilterMethod.invoke(hive, table, filter))
val full = Try(getAllPartitionsMethod.invoke(hive, table))
logError("getPartitionsByFilter failed, retry success = " + retry.isSuccess)
logError("getPartitionsByFilter failed, full fetch success = " + full.isSuccess)
Copy link
Contributor

@yhuai yhuai Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should also log all of partition specs?

Copy link
Contributor Author

@ericl ericl Oct 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good idea, we should definitely do it if turns out the retry fails

throw e
}
}

partitions.asScala.toSeq
Expand Down