[SPARK-18167] [SQL] Add debug code for SQLQuerySuite flakiness when metastore partition pruning is enabled #15676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuai
reviewed
Oct 28, 2016
| val retry = Try(getPartitionsByFilterMethod.invoke(hive, table, filter)) | ||
| val full = Try(getAllPartitionsMethod.invoke(hive, table)) | ||
| logError("getPartitionsByFilter failed, retry success = " + retry.isSuccess) | ||
| logError("getPartitionsByFilter failed, full fetch success = " + full.isSuccess) |
Contributor
There was a problem hiding this comment.
I am wondering if we should also log all of partition specs?
Contributor
Author
There was a problem hiding this comment.
Yeah that's a good idea, we should definitely do it if turns out the retry fails
|
Test build #67727 has finished for PR 15676 at commit
|
|
Test build #67728 has finished for PR 15676 at commit
|
Contributor
|
Merging in first so we can get more signal. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…tastore partition pruning is enabled
## What changes were proposed in this pull request?
org.apache.spark.sql.hive.execution.SQLQuerySuite is flaking when hive partition pruning is enabled.
Based on the stack traces, it seems to be an old issue where Hive fails to cast a numeric partition column ("Invalid character string format for type DECIMAL"). There are two possibilities here: either we are somehow corrupting the partition table to have non-decimal values in that column, or there is a transient issue with Derby.
This PR logs the result of the retry when this exception is encountered, so we can confirm what is going on.
## How was this patch tested?
n/a
cc yhuai
Author: Eric Liang <[email protected]>
Closes apache#15676 from ericl/spark-18167.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…tastore partition pruning is enabled
## What changes were proposed in this pull request?
org.apache.spark.sql.hive.execution.SQLQuerySuite is flaking when hive partition pruning is enabled.
Based on the stack traces, it seems to be an old issue where Hive fails to cast a numeric partition column ("Invalid character string format for type DECIMAL"). There are two possibilities here: either we are somehow corrupting the partition table to have non-decimal values in that column, or there is a transient issue with Derby.
This PR logs the result of the retry when this exception is encountered, so we can confirm what is going on.
## How was this patch tested?
n/a
cc yhuai
Author: Eric Liang <[email protected]>
Closes apache#15676 from ericl/spark-18167.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
org.apache.spark.sql.hive.execution.SQLQuerySuite is flaking when hive partition pruning is enabled.
Based on the stack traces, it seems to be an old issue where Hive fails to cast a numeric partition column ("Invalid character string format for type DECIMAL"). There are two possibilities here: either we are somehow corrupting the partition table to have non-decimal values in that column, or there is a transient issue with Derby.
This PR logs the result of the retry when this exception is encountered, so we can confirm what is going on.
How was this patch tested?
n/a
cc @yhuai