Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit) #16091 #17714

Merged
merged 16 commits into from
May 16, 2022

Conversation

yangsen00
Copy link
Contributor

Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)

@codecov-commenter
Copy link

Codecov Report

Merging #17714 (0d46b06) into master (120d4f5) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0d46b06 differs from pull request most recent head b87ec15. Consider uploading reports for the commit b87ec15 to get more accurate results

@@            Coverage Diff            @@
##             master   #17714   +/-   ##
=========================================
  Coverage     58.81%   58.82%           
  Complexity     2126     2126           
=========================================
  Files          3599     3599           
  Lines         53567    53567           
  Branches       9146     9146           
=========================================
+ Hits          31508    31512    +4     
+ Misses        19385    19380    -5     
- Partials       2674     2675    +1     
Impacted Files Coverage Δ
...d/text/distsql/ral/common/hint/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
.../mode/metadata/persist/MetaDataPersistService.java 72.00% <0.00%> (+14.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120d4f5...b87ec15. Read the comment docs.

@terrymanu terrymanu added this to the 5.1.2 milestone May 16, 2022
@terrymanu terrymanu merged commit cab7784 into apache:master May 16, 2022
@yangsen00 yangsen00 deleted the dev-16091 branch May 17, 2022 01:38
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 17, 2022
* master: (90 commits)
  Remove usage of com.google.common.collect.Collections2 (apache#17721)
  Refactor execute RAL  statement reload metaData (apache#17720)
  Use caffeine instead of guava cache (apache#17712)
  Minor changes for test cases and code format (apache#17718)
  Add test case for RuleBasedSchemaMetaDataBuilderFactory . (apache#17709)
  Update Mockito and ByteBuddy to help with GraalVM integration (apache#17665)
  fix CI error (apache#17713)
  Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)  apache#16091 (apache#17714)
  Remove useless DatabaseMetaDataContextsBuilder (apache#17717)
  private MetaDataContextsBuilder.addDatabase and addSystemDatabases (apache#17716)
  Add unit test for ModShardingAlgorithm  (apache#17710)
  Refactor distribute database lock (apache#17711)
  Add unit test for Bootstrap use proxy default port from props (apache#17707)
  Scaling IT optimization (apache#17702)
  Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . (apache#17701)
  Use ConfigurationProperties in ContextManager (apache#17706)
  Use ConfigurationProperties in MetaDataContextsBuilder (apache#17705)
  Refactor create schema statement parse logic (apache#17703)
  Revise apache#17695 (apache#17700)
  add test for DataNodeBuilderFactory (apache#17695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants