Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit) need add unit test. #16091

Closed
zhaojinchao95 opened this issue Mar 15, 2022 · 11 comments
Closed

MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit) need add unit test. #16091

zhaojinchao95 opened this issue Mar 15, 2022 · 11 comments
Labels
good first issue in: test mode: cluster

Comments

@zhaojinchao95
Copy link
Contributor

No description provided.

@shreya024
Copy link
Contributor

Hi, I am Shreya, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you

@sandynz
Copy link
Contributor

sandynz commented Mar 21, 2022

@shreya024 Welcome!

@shreya024 shreya024 mentioned this issue Mar 21, 2022
Closed
@shreya024 shreya024 removed their assignment Apr 3, 2022
@yangsen00
Copy link
Contributor

Hello，dose this issues need someone to solve? maybe I can.

@sandynz
Copy link
Contributor

sandynz commented Apr 15, 2022

@yangsen00 , Welcome!

@zhaojinchao95
Copy link
Contributor Author

Hello，dose this issues need someone to solve? maybe I can.

@yangsen00 Hi, how is this mission going?

@yangsen00
Copy link
Contributor

Hello，dose this issues need someone to solve? maybe I can.

@yangsen00 Hi, how is this mission going?
I'm busy for my work.I'll finish it this week

@zhaojinchao95
Copy link
Contributor Author

Hello，dose this issues need someone to solve? maybe I can.

@yangsen00 Hi, how is this mission going?
I'm busy for my work.I'll finish it this week

OK, i 'm looking forward.

terrymanu pushed a commit that referenced this issue May 16, 2022
@yangsen00 @tclxsen4-yang
Add unit for MetaDataPersistService.persistTransactionRule(final Prop…
cab7784 
…erties props, final boolean isOverwrit) #16091 (#17714)

* Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit) (#16091)

Co-authored-by: yangsen <[email protected]>
Co-authored-by: sen4.yang <[email protected]>
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this issue May 17, 2022
@zhaoguhong
Merge branch 'master' into 17196
46f0565 
* master: (90 commits)
  Remove usage of com.google.common.collect.Collections2 (apache#17721)
  Refactor execute RAL  statement reload metaData (apache#17720)
  Use caffeine instead of guava cache (apache#17712)
  Minor changes for test cases and code format (apache#17718)
  Add test case for RuleBasedSchemaMetaDataBuilderFactory . (apache#17709)
  Update Mockito and ByteBuddy to help with GraalVM integration (apache#17665)
  fix CI error (apache#17713)
  Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)  apache#16091 (apache#17714)
  Remove useless DatabaseMetaDataContextsBuilder (apache#17717)
  private MetaDataContextsBuilder.addDatabase and addSystemDatabases (apache#17716)
  Add unit test for ModShardingAlgorithm  (apache#17710)
  Refactor distribute database lock (apache#17711)
  Add unit test for Bootstrap use proxy default port from props (apache#17707)
  Scaling IT optimization (apache#17702)
  Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . (apache#17701)
  Use ConfigurationProperties in ContextManager (apache#17706)
  Use ConfigurationProperties in MetaDataContextsBuilder (apache#17705)
  Refactor create schema statement parse logic (apache#17703)
  Revise apache#17695 (apache#17700)
  add test for DataNodeBuilderFactory (apache#17695)
  ...
@yangsen00
Copy link
Contributor

hello,could this close?

@terrymanu
Copy link
Member

@yangsen00 Hi, there are no progress for long time, I just cancel assign to you and make the issue open to pick up.

@yangsen00
Copy link
Contributor

@yangsen00 Hi, there are no progress for long time, I just cancel assign to you and make the issue open to pick up.

I have created a PR，and code have merged into master，maybe it should closed

@zhaojinchao95
Copy link
Contributor Author

@yangsen00 Hi, there are no progress for long time, I just cancel assign to you and make the issue open to pick up.

I have created a PR，and code have merged into master，maybe it should closed

Yeah, it 's finished, i close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in: test mode: cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

persist Transaction rule test added
5 participants
@terrymanu @zhaojinchao95 @sandynz @shreya024 @yangsen00