FIX #11687 issue add unit test #11715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristaZero
requested changes
Aug 10, 2021
…governance mode (apache#11649) * fix : apache#11643 Custom pool properties are lost when restarted in governance mode * doc : apache#11643 modify doc * refactor : flip '.equals()' * fix : apache#11643 Custom pool properties are lost when restarted in governance mode * Use .isEmpty() to replace the hasCustomPoolProps() * Move CUSTOM_POOL_PROPS_KEY to the DataSourceConfiguration class * Modify the judgment condition
…e#11717) * revert part of PR#10840 code to ensure GlobalRule load order * move todo comment * add LinkedHashMap wrapper * add default schema name for integration test
* jdbc-core module delete getDefaultMetaData() * update * optimization
* fix ci * little change
* Migrate YAML Configuration change history from 4.1.2.Configuration Manual->YAML Configuration->Change History to 7.2.API Change History->7.2.1.ShardingSphere-JDBC->YAML Configuration; * Add content of change history * Add test of ExecuteProcessEngine. * Modify the test code format of ExecuteProcessEngine. * Modify the test code format of ExecuteProcessEngine. Add a test for ExecuteProcessEngine.finish(final String executionID, final SQLExecutionUnit executionUnit). * Update creatLogicSQL() and createConfigurationProperties() using mock. * modify createMockedExecutionGroups(final int groupSize, final int unitSize) to only create mock ExecutionGroupContext object. modify assertTrue to assertThat. * modify createMockedExecutionGroups(final int groupSize, final int unitSize) to createMockedExecutionGroups(); modify all assertTrue to assertThat. use UUID.randomUUID().toString() as executionGroupContext.executionID
* Renew transaction context after schema was deleted * Renew transaction context after schema was deleted * Renew transaction context after schema was deleted
* Refactor ShardingRuleSQLStatementVisitor * Add ShardingSphereMode * Add impl of ShardingSphereMode * Merge conflicts * Add todo for update meta data context in memory * Update MetaDataContexts.getDistMetaDataPersistService() * Use mode in ShardingSphereDataSource * Use mode in ShardingSphereDataSource * Use mode in GovernanceShardingSphereDataSource * Use mode in Proxy
…che#11733) * delete getDefaultEngines method for TransactionContexts interface * fixed
* Modify the document * Keep space between Chinese and English
|
re pull code |
|
merge newest code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11687.
add unit test for :