Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for shardingsphere-shadow-core #11687

Closed
3 tasks
soulasuna opened this issue Aug 6, 2021 · 4 comments · Fixed by #11754
Closed
3 tasks

Add unit test for shardingsphere-shadow-core #11687

soulasuna opened this issue Aug 6, 2021 · 4 comments · Fixed by #11754
Assignees
@WtlKoma
Labels
feature: shadow good first issue
Milestone
5.0.0

Comments

@soulasuna
Copy link
Contributor

Hi community,

This issue is for #11661

Aim

Add unit test for shardingsphere-shadow-core project to test its public functions.

Basic Qualifications

  • Java
  • Maven
  • Junit.Test

Classes

Add unit test for classes to test its public functions.

  • ShadowDataSourceConfigurationYamlSwapper
  • ShadowTableConfigurationYamlSwapper
  • ShadowRuleAlgorithmProviderConfigurationYamlSwapper

Examples FYI

  • ShadowRuleConfigurationYamlSwapperTest
  • YamlRootRuleConfigurationsForYamlShadowRuleConfigurationTest
@strongduanmu strongduanmu added this to the 5.0.0-RC1 milestone Aug 6, 2021
@WtlKoma
Copy link

WtlKoma commented Aug 6, 2021

I want do this.

@strongduanmu
Copy link
Member

@WtlKoma Welcome.

hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 9, 2021
@hoorf
FIX apache#11687 issue add unit test
3810f14
@hoorf hoorf mentioned this issue Aug 9, 2021
Closed
hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 9, 2021
@hoorf
FIX apache#11687 issue add unit test
ad23995
hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 9, 2021
@hoorf
FIX apache#11687 issue add unit test
e5dce08
@hoorf
Copy link
Contributor

hoorf commented Aug 9, 2021

may be unit test will change for fixme tags remove

@soulasuna
Copy link
Contributor Author

may be unit test will change for fixme tags remove

Thank you very much for reminding. But that is something to be done after all the refactoring is completed.

hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 11, 2021
@hoorf
FIX apache#11687 issue add unit test
3edd041
@hoorf hoorf mentioned this issue Aug 11, 2021
Merged
hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 11, 2021
@hoorf
FIX apache#11687 issue add unit test
b8b9505
hoorf added a commit to hoorf/shardingsphere that referenced this issue Aug 11, 2021
@hoorf
FIX apache#11687 issue add unit test
aceaa86
menghaoranss pushed a commit that referenced this issue Aug 11, 2021
@hoorf
FIX #11687 issue add unit test (#11754)
dbf26a2 
* FIX #11687 issue add unit test

* FIX #11687 issue add unit test
@menghaoranss menghaoranss modified the milestones: 5.0.0-RC1, 5.0.0 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WtlKoma WtlKoma

Labels
feature: shadow good first issue
Projects
None yet
Milestone
5.0.0
5 participants
@hoorf @strongduanmu @soulasuna @WtlKoma @menghaoranss