[Fix] logs http basic issue # 9755 #9968

wuxiansen · 2025-10-20T06:23:53Z

Fix logs Basic issue

Contribution Checklist

Purpose of this pull request

This pull request supplements test cases for fixing basic log-related issues, ensuring that the logging functionality works correctly in scenarios where HTTP Basic authentication is enabled. By adding the RestApiHttpBasicTest test class, it verifies the correctness of log-related REST API responses with Basic authentication, including interface accessibility, response format, and content integrity, further ensuring the stability of the logging feature.

Does this PR introduce any user-facing change?

No. The added test cases are solely for internal functional verification and do not involve changes to user-visible behaviors, configuration methods, or output results. They have no impact on user workflows.

How was this patch tested?

New test cases: The RestApiHttpBasicTest class was implemented to specifically test the behavior of log-related REST APIs when HTTP Basic authentication is enabled, including:
Verifying that the /overview endpoint returns a 200 OK status and contains necessary fields (e.g., projectVersion) with valid authentication.
Testing the /logs endpoint with different formats (e.g., JSON) to check for non-empty responses, correct status codes, and expected Content-Type headers.
Simulating job submission and validating that the log endpoint correctly returns job log information.
Test environment: A test cluster was set up using Hazelcast in local mode, with HTTP port and Basic authentication credentials (username admin, password admin) configured to match real-world scenarios.
Execution method: Tests were run using JUnit 5 to automatically verify interface behavior. All assertions passing indicate that the functionality works as expected.

Check list

If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
If you are contributing the connector code, please check that the following files are updated:
1. Update plugin-mapping.properties and add new connector information in it
2. Update the pom file of seatunnel-dist
3. Add ci label in label-scope-conf
4. Add e2e testcase in seatunnel-e2e
5. Update connector plugin_config

Fix logs Basic issue

wuxiansen · 2025-10-20T06:44:45Z

@hailin0 @davidzollo Hello, can you help me take a look at this PR?

Modify code style

Modify DisabledOnOs OS.WINDOWS

wuxiansen · 2025-10-28T08:37:07Z

@hailin0 @davidzollo Hello, can you help me take a look at this PR?

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

PTAL

dybyte · 2025-10-28T08:57:29Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Closure processing

wuxiansen · 2025-10-29T10:23:59Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Executing the failures one by one can be done .

@liucongjy @zhangshenghang

BaseServletTest.testWriteJsonWithObject can pass the test locally, but why can't it pass in actions?

PTAL

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    BaseServletTest.testWriteJsonWithObject:71->testLogRestApiResponse:147 expected: <200> but was: <401>
Error:  Errors: 
Error:    RestApiHttpsForTruststoreTest.testRestApiHttps:136 » IO Server returned HTTP r...
Error:    RestApiHttpsTest.testRestApiHttp:88 » IO Server returned HTTP response code: 4...
Error:    RestApiHttpsTest.testRestApiHttps:109 » IO Server returned HTTP response code:...
[INFO] 
Error:  Tests run: 96, Failures: 1, Errors: 3, Skipped: 6
[INFO]

https://github.com/wuxiansen/seatunnel/actions/runs/18870236917/job/53957365698

ConfigProvider.locateAndGetSeaTunnelConfig() single-case , Use case is reset later

wuxiansen · 2025-10-30T15:55:37Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Executing the failures one by one can be done .

@liucongjy @zhangshenghang

BaseServletTest.testWriteJsonWithObject can pass the test locally, but why can't it pass in actions?

PTAL
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    BaseServletTest.testWriteJsonWithObject:71->testLogRestApiResponse:147 expected: <200> but was: <401>
Error:  Errors: 
Error:    RestApiHttpsForTruststoreTest.testRestApiHttps:136 » IO Server returned HTTP r...
Error:    RestApiHttpsTest.testRestApiHttp:88 » IO Server returned HTTP response code: 4...
Error:    RestApiHttpsTest.testRestApiHttps:109 » IO Server returned HTTP response code:...
[INFO] 
Error:  Tests run: 96, Failures: 1, Errors: 3, Skipped: 6
[INFO] 
https://github.com/wuxiansen/seatunnel/actions/runs/18870236917/job/53957365698

I seem to have found the problem. The setUP method is a bit confusing, making people think that each test class is independent, but in fact it is not. ConfigProvider.locateAndGetSeaTunnelConfig() single-case, unified management through org.apache.seatunnel.engine.common.config.YamlSeaTunnelDomConfigProcessor. as it happens
The newly added RestApiHttpBasicTest class is executed first, as can be seen from the following log.

Oct 30, 2025 5:21:59 AM com.hazelcast.internal.server.tcp.TcpServerConnection
INFO: [localhost]:5801 [runner_CoordinatorServiceTest_testCleanPendingJobMasterMap] [5.1] Connection[id=13, /127.0.0.1:5801->/127.0.0.1:37651, qualifier=null, endpoint=[localhost]:5803, remoteUuid=048f417e-3de9-4ff1-a253-e33d2ba479a8, alive=false, connectionType=MEMBER, planeIndex=0] closed. Reason: Connection closed by the other side
org.apache.seatunnel.engine.common.loader.SeaTunnelChildFirstClassLoader@2759114
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.807 s - in org.apache.seatunnel.engine.server.rest.RestApiHttpBasicTest
[INFO] Running org.apache.seatunnel.engine.server.rest.RestApiHttpsForTruststoreTest
Oct 30, 2025 5:22:01 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'

...

Oct 30, 2025 5:22:02 AM com.hazelcast.internal.server.tcp.TcpServerConnection
INFO: [localhost]:5801 [runner_CoordinatorServiceTest_testCleanPendingJobMasterMap] [5.1] Connection[id=15, /127.0.0.1:5801->/127.0.0.1:43985, qualifier=null, endpoint=[localhost]:5804, remoteUuid=92d3d57e-c593-42cd-a4f6-6cea21527200, alive=false, connectionType=MEMBER, planeIndex=0] closed. Reason: Connection closed by the other side
org.apache.seatunnel.engine.common.loader.SeaTunnelChildFirstClassLoader@2759114
Error:  Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.586 s <<< FAILURE! - in org.apache.seatunnel.engine.server.rest.RestApiHttpsForTruststoreTest
Error:  testRestApiHttps  Time elapsed: 0.124 s  <<< ERROR!
java.io.IOException: Server returned HTTP response code: 401 for URL: https://localhost:18443/overview
	at org.apache.seatunnel.engine.server.rest.RestApiHttpsForTruststoreTest.testRestApiHttps(RestApiHttpsForTruststoreTest.java:136)

[INFO] Running org.apache.seatunnel.engine.server.rest.RestApiHttpsTest
Oct 30, 2025 5:22:03 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'

...

Oct 30, 2025 5:22:05 AM com.hazelcast.internal.server.tcp.TcpServerConnection
INFO: [localhost]:5801 [runner_CoordinatorServiceTest_testCleanPendingJobMasterMap] [5.1] Connection[id=17, /127.0.0.1:5801->/127.0.0.1:36841, qualifier=null, endpoint=[localhost]:5805, remoteUuid=6f488a61-6344-43da-9a6c-3070b4321d7e, alive=false, connectionType=MEMBER, planeIndex=0] closed. Reason: Connection closed by the other side
org.apache.seatunnel.engine.common.loader.SeaTunnelChildFirstClassLoader@2759114
Oct 30, 2025 5:22:05 AM org.apache.seatunnel.engine.server.CoordinatorService
INFO: [localhost]:5801 [runner_CoordinatorServiceTest_testCleanPendingJobMasterMap] [5.1] 
Error:  Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.293 s <<< FAILURE! - in org.apache.seatunnel.engine.server.rest.RestApiHttpsTest
Error:  testRestApiHttps  Time elapsed: 0.036 s  <<< ERROR!
java.io.IOException: Server returned HTTP response code: 401 for URL: https://localhost:28443/overview
	at org.apache.seatunnel.engine.server.rest.RestApiHttpsTest.testRestApiHttps(RestApiHttpsTest.java:109)

Error:  testRestApiHttp  Time elapsed: 0.005 s  <<< ERROR!
java.io.IOException: Server returned HTTP response code: 401 for URL: http://localhost:28080/overview
	at org.apache.seatunnel.engine.server.rest.RestApiHttpsTest.testRestApiHttp(RestApiHttpsTest.java:88)

[INFO] Running org.apache.seatunnel.engine.server.rest.BaseServletTest
Oct 30, 2025 5:22:06 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'
Oct 30, 2025 5:22:06 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Using configuration file at /home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml
Oct 30, 2025 5:22:06 AM org.apache.seatunnel.engine.common.config.YamlSeaTunnelDomConfigProcessor
INFO: Dynamic slot is enabled, the schedule strategy is set to REJECT
Oct 30, 2025 5:22:06 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading 'hazelcast.yaml' from the classpath.
Oct 30, 2025 5:22:06 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'

...

Error:  Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.349 s <<< FAILURE! - in org.apache.seatunnel.engine.server.rest.BaseServletTest
Error:  testWriteJsonWithObject  Time elapsed: 0.027 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <200> but was: <401>
	at org.apache.seatunnel.engine.server.rest.BaseServletTest.testLogRestApiResponse(BaseServletTest.java:147)
	at org.apache.seatunnel.engine.server.rest.BaseServletTest.testWriteJsonWithObject(BaseServletTest.java:71)

[INFO] Running org.apache.seatunnel.engine.server.CoordinatorServiceWithCancelPendingJobTest
Oct 30, 2025 5:22:08 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'
Oct 30, 2025 5:22:08 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Using configuration file at /home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml
Oct 30, 2025 5:22:08 AM org.apache.seatunnel.engine.common.config.YamlSeaTunnelDomConfigProcessor
INFO: Dynamic slot is enabled, the schedule strategy is set to REJECT
Oct 30, 2025 5:22:08 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading 'hazelcast.yaml' from the classpath.
Oct 30, 2025 5:22:08 AM com.hazelcast.internal.config.AbstractConfigLocator
INFO: Loading configuration '/home/runner/work/seatunnel/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/resources/seatunnel.yaml' from System property 'seatunnel.config'

Local reproduction is reproduced by using the following command:

 mvn -pl seatunnel-engine/seatunnel-engine-server test -Dtest=RestApiHttpBasicTest,BaseServletTest,RestApiHttpsTest,RestApiHttpsForTruststoreTest -DfailIfNoTests=false

Solution: After setting RestApiHttpBasicTest, use AfterAll to clean up the Basic configuration.

PR

# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/LogService.java

wuxiansen · 2025-10-31T17:53:56Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Use case execution is completed. I re-executed it several times, and the redis test case has a high probability of failure. I re-executed it many times, but luckily it finally worked.

PTAL

wuxiansen · 2025-11-04T02:03:51Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Use case execution is completed. I re-executed it several times, and the redis test case has a high probability of failure. I re-executed it many times, but luckily it finally worked.

PTAL

I’ve been keeping an eye on it lately, and it doesn’t seem like there’s been much progress. If you have any ideas or think we need to make adjustments, we can talk it through together. 🤝

dybyte · 2025-11-04T10:35:19Z

I only fix a certain piece of content, and the other module code has not changed. Why do module test cases that have not changed keep compiling fail?

Please pull the latest changes and try again.

Use case execution is completed. I re-executed it several times, and the redis test case has a high probability of failure. I re-executed it many times, but luckily it finally worked.
PTAL

I’ve been keeping an eye on it lately, and it doesn’t seem like there’s been much progress. If you have any ideas or think we need to make adjustments, we can talk it through together. 🤝

I’ve opened a PR addressing the flaky Redis tests. #10024
Thanks for reporting this issue!

dybyte · 2025-11-05T07:48:49Z

cc @zhangshenghang @hawk9821 — could you please take a look when you have a moment?

dybyte

Thanks @wuxiansen

...ngine-server/src/test/java/org/apache/seatunnel/engine/server/rest/RestApiHttpBasicTest.java

...ine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java

...-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/LogService.java

...ine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java

...-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/LogService.java

...seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/HttpBasic.java

...ngine-server/src/test/java/org/apache/seatunnel/engine/server/rest/RestApiHttpBasicTest.java

# 9755

...ngine-server/src/test/java/org/apache/seatunnel/engine/server/rest/RestApiHttpBasicTest.java

…che/seatunnel/engine/server/rest/RestApiHttpBasicTest.java Co-authored-by: dy102 <[email protected]>

# 9755

dybyte

LGTM if CI passes. Thanks @wuxiansen

...ine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java

# 9755

zhangshenghang

LGTM， If CI pass

github-actions bot added Zeta Zeta Rest API labels Oct 20, 2025

dayan1852 added 2 commits October 20, 2025 14:27

# 9755

0057b66

Fix logs Basic issue

Trigger workflow

50a94be

wuxiansen changed the title ~~# 9755~~ [Fix] logs Basic issue # 9755 Oct 20, 2025

wuxiansen changed the title ~~[Fix] logs Basic issue # 9755~~ [Fix] logs http basic issue # 9755 Oct 20, 2025

wuxiansen force-pushed the feature-9755 branch from 336d557 to 50a94be Compare October 20, 2025 08:04

dayan1852 added 3 commits October 20, 2025 16:04

Trigger workflow

d3175f1

# 9755

4160872

Modify code style

# 9755

e84a1e3

Modify DisabledOnOs OS.WINDOWS

dayan1852 added 2 commits October 28, 2025 17:22

# 9755

01e3f21

Closure processing

Merge remote-tracking branch 'upstream/dev' into feature-9755

f6d6b82

dayan1852 added 2 commits October 30, 2025 12:49

Trigger workflow

704d697

# 9755

d62105c

ConfigProvider.locateAndGetSeaTunnelConfig() single-case , Use case is reset later

Merge remote-tracking branch 'upstream/dev' into feature-9755

0469e63

# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/LogService.java

dybyte mentioned this pull request Nov 5, 2025

[Bug] [restful api ] After enabling Basic authentication, downloading the log file results in a JSON deserialization exception. #10027

Open

3 tasks

dybyte reviewed Nov 5, 2025

View reviewed changes

dayan1852 added 3 commits November 6, 2025 11:31

Code optimization

1fa4063

# 9755

Merge remote-tracking branch 'upstream/dev' into feature-9755

55f3cbf

Code optimization

013e0ac

# 9755

dayan1852 added 2 commits November 6, 2025 15:42

Code optimization

63ea988

# 9755

Code optimization

84e26e9

# 9755

dybyte reviewed Nov 6, 2025

View reviewed changes

...ngine-server/src/test/java/org/apache/seatunnel/engine/server/rest/RestApiHttpBasicTest.java Outdated Show resolved Hide resolved

wuxiansen and others added 2 commits November 6, 2025 17:20

Update seatunnel-engine/seatunnel-engine-server/src/test/java/org/apa…

22cb2be

…che/seatunnel/engine/server/rest/RestApiHttpBasicTest.java Co-authored-by: dy102 <[email protected]>

import StringUtils

9e6c2ec

# 9755

dybyte approved these changes Nov 6, 2025

View reviewed changes

github-actions bot added the reviewed label Nov 6, 2025

zhangshenghang reviewed Nov 6, 2025

View reviewed changes

...ine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java Show resolved Hide resolved

zhangshenghang reviewed Nov 6, 2025

View reviewed changes

...ine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java Outdated Show resolved Hide resolved

Optimize sendGet method

a01750a

# 9755

zhangshenghang approved these changes Nov 6, 2025

View reviewed changes

github-actions bot added the approved label Nov 6, 2025

corgy-w approved these changes Nov 8, 2025

View reviewed changes

corgy-w merged commit b1a4be9 into apache:dev Nov 8, 2025
6 checks passed

wuxiansen deleted the feature-9755 branch November 9, 2025 03:20

[Fix] logs http basic issue # 9755 #9968

[Fix] logs http basic issue # 9755 #9968

Conversation

wuxiansen commented Oct 20, 2025

Contribution Checklist

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Uh oh!

wuxiansen commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuxiansen commented Oct 28, 2025

Uh oh!

dybyte commented Oct 28, 2025

Uh oh!

wuxiansen commented Oct 29, 2025

Uh oh!

wuxiansen commented Oct 30, 2025

Uh oh!

wuxiansen commented Oct 31, 2025

Uh oh!

wuxiansen commented Nov 4, 2025

Uh oh!

dybyte commented Nov 4, 2025

Uh oh!

dybyte commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dybyte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dybyte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zhangshenghang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wuxiansen commented Oct 20, 2025 •

edited

Loading

dybyte commented Nov 5, 2025 •

edited

Loading