Skip to content

Conversation

@dybyte
Copy link
Contributor

@dybyte dybyte commented Nov 4, 2025

Purpose of this pull request

This PR fixes flaky Redis tests.

2025-10-30T21:33:29.1934764Z [ERROR] Failures: 
2025-10-30T21:33:29.1935455Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1937019Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1938065Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1939086Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1940211Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1941290Z [ERROR]   RedisClusterIT.testRedisClusterCustomValueWithListType:349 expected: <100> but was: <132>
2025-10-30T21:33:29.1942187Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>
2025-10-30T21:33:29.1943049Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>
2025-10-30T21:33:29.1943823Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>
2025-10-30T21:33:29.1944866Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>
2025-10-30T21:33:29.1945655Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>
2025-10-30T21:33:29.1946415Z [ERROR]   RedisClusterIT.testRedisClusterScan:294 expected: <100> but was: <132>

The RedisClusterIT test class involves multiple Redis clusters, which can lead to race conditions in the sink, resulting in duplicate writes.
Given that the batch size is 33, a total of 33 × 4 = 132 records can occasionally appear due to this race condition.
To address this, I modified some test cases that handle the List type.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Covered by existing tests.

Check list

@github-actions github-actions bot added the e2e label Nov 4, 2025
@dybyte dybyte mentioned this pull request Nov 4, 2025
3 tasks
@chl-wxp
Copy link
Contributor

chl-wxp commented Nov 4, 2025

Thank you very much, I also encountered this problem

@dybyte dybyte marked this pull request as draft November 4, 2025 15:17
@dybyte dybyte marked this pull request as ready for review November 4, 2025 18:03
Copy link
Contributor

@chl-wxp chl-wxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 5238292 into apache:dev Nov 6, 2025
7 checks passed
@dybyte dybyte deleted the fix/redis-ci branch November 10, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants