Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8438] Fix broker return two messages when query message and index service bug #8439

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Jul 24, 2024

Fix broker return two messages when query message and index service bug

Which Issue(s) This PR Fixes

Fixes #8438

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.68%. Comparing base (6e6319f) to head (40ea66d).

Files Patch % Lines
...pache/rocketmq/tieredstore/TieredMessageStore.java 50.00% 0 Missing and 1 partial ⚠️
...che/rocketmq/tieredstore/index/IndexStoreFile.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8439      +/-   ##
=============================================
+ Coverage      45.67%   45.68%   +0.01%     
- Complexity     11052    11055       +3     
=============================================
  Files           1274     1274              
  Lines          88997    89001       +4     
  Branches       11440    11441       +1     
=============================================
+ Hits           40649    40664      +15     
+ Misses         43295    43270      -25     
- Partials        5053     5067      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma
Copy link
Contributor

drpmma commented Jul 25, 2024

LGTM

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit c080e6b into apache:develop Jul 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The broker will return two messages when query message
3 participants