Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7963] Check consumer group existence in updateConsumerOffset #7964

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Mar 25, 2024

Which Issue(s) This PR Fixes

Fixes #7963

Brief Description

Check the existence of consumer group in command updateConsumerOffset. Return SUBSCRIPTION_GROUP_NOT_EXIST if the group has been deleted.

How Did You Test This Change?

UT

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.81%. Comparing base (d1cc742) to head (9e2b42e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7964      +/-   ##
=============================================
- Coverage      42.84%   42.81%   -0.03%     
+ Complexity     10349    10348       -1     
=============================================
  Files           1270     1270              
  Lines          88607    88621      +14     
  Branches       11394    11396       +2     
=============================================
- Hits           37960    37945      -15     
- Misses         45959    45991      +32     
+ Partials        4688     4685       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins
Copy link
Member

lizhimins commented Mar 27, 2024

Do we need to consider the logic of "auto create subscription" here?

@redlsz
Copy link
Contributor Author

redlsz commented Mar 28, 2024

Do we need to consider the logic of "auto create subscription" here?

IMO, no impacts. The logic of "auto create subscription" is handled when the client sending a heartbeat for the first time, before the client actually receives some messages. So if an updateConusmerOffset request needs to be processed, the consumer group must have been created.

@lizhimins lizhimins merged commit b39f65e into apache:develop Apr 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Check the existence of consumer group in updateConsumerOffset to prevent dirty consumer offsets
9 participants