Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Check the existence of consumer group in updateConsumerOffset to prevent dirty consumer offsets #7963

Closed
1 task done
redlsz opened this issue Mar 25, 2024 · 0 comments · Fixed by #7964
Closed
1 task done

Comments

@redlsz
Copy link
Contributor

redlsz commented Mar 25, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Check the existence of consumer group in command updateConsumerOffset. Return SUBSCRIPTION_GROUP_NOT_EXIST if the group has been deleted.

Motivation

In scenarios where consumer group need to be deleted, if deleteSubscriptionGroup admin is called before shutting down the online consumer clients, the consumer offset records, which is dirty, might be kept in broker. This could raise some problems, such as getting incorrect data when calling queryTopicConsumeByWho.

image image

This is not the good way to use rmq, but it would occur, and be uncontrollable to broker.

Describe the Solution You'd Like

Check the existence of consumer group in command updateConsumerOffset. Return SUBSCRIPTION_GROUP_NOT_EXIST if the group has been deleted.

Describe Alternatives You've Considered

/

Additional Context

No response

@redlsz redlsz changed the title [Enhancement] Check the existence of consumer group in updateConsumerOffset to prevent the generation of dirty consumer offsets [Enhancement] Check the existence of consumer group in updateConsumerOffset to prevent dirty consumer offsets Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant