Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE ##7036] rename method: getWriteQueueIdByBroker to getWriteQueu… #7037

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[ISSUE ##7036] rename method: getWriteQueueIdByBroker to getWriteQueu… #7037

merged 3 commits into from
Jul 20, 2023

Conversation

yao-wenbin
Copy link
Contributor

@yao-wenbin yao-wenbin commented Jul 18, 2023

Which Issue(s) This PR Fixes

Fixes #7036

Brief Description

rename method in TopicPublishInfo from getWriteQueueIdByBroker to getWriteQueueNumsByBroker for better understand and readable. Becasue the method is to get the writequeue nums in broker instead of id.

image

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yao-wenbin
Copy link
Contributor Author

yao-wenbin commented Jul 19, 2023

Build and Run Tests by Maven / maven-compile (macos-latest, JDK-8) (pull_request) encounter a failure, I don't know how to resolve this problem.
Would you guys give me some help? @mxsm @ferrirW @TheR1sing3un

@RongtongJin RongtongJin merged commit 804f2d8 into apache:develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] rename method: getWriteQueueIdByBroker to getWriteQueueNumsByBroker.
5 participants