Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] rename method: getWriteQueueIdByBroker to getWriteQueueNumsByBroker. #7036

Closed
1 task done
yao-wenbin opened this issue Jul 18, 2023 · 0 comments · Fixed by #7037
Closed
1 task done

[Enhancement] rename method: getWriteQueueIdByBroker to getWriteQueueNumsByBroker. #7036

yao-wenbin opened this issue Jul 18, 2023 · 0 comments · Fixed by #7037
Labels
type/enhancement

Comments

@yao-wenbin
Copy link
Contributor

yao-wenbin commented Jul 18, 2023 •
edited
Loading

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

the method in TopicPublishInfo to get Broker's writeQueueNum named getWriteQueueNumsByBroker will be better to read and understand, instead of getWriteQueueIdByBroker.

image image

Motivation

to be better understood and readable.

Describe the Solution You'd Like

rename the method getWriteQueueIdByBroker to getWriteQueueNumsByBroker.

Describe Alternatives You've Considered

it will by easy to misunderstand, if keep the name getWriteQueueIdByBroker.

Additional Context

No response
@yao-wenbin yao-wenbin changed the title [Enhancement] rename method: getWriteQueueIdByBroker to getWriteQueueNumByBroker. [Enhancement] rename method: getWriteQueueIdByBroker to getWriteQueueNumsByBroker. Jul 18, 2023
@yao-wenbin yao-wenbin mentioned this issue Jul 18, 2023
Merged
RongtongJin pushed a commit that referenced this issue Jul 20, 2023
@yao-wenbin
[ISSUE ##7036] rename method: getWriteQueueIdByBroker to getWriteQueu…
804f2d8 
…eNumsByBroker(#7037)

* [ISSUE ##7036] rename method: getWriteQueueIdByBroker to getWriteQueueNumsByBroker

* [ISSUE #7036] rename method from getWriteQueueIdByBroker to getWriteQueueNumsByBroker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE ##7036] rename method: getWriteQueueIdByBroker to getWriteQueu…
1 participant
@yao-wenbin