Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #6123] Fix flaky test in tiered storage #6124

Merged
merged 4 commits into from
Feb 21, 2023
Merged

[ISSUE #6123] Fix flaky test in tiered storage #6124

merged 4 commits into from
Feb 21, 2023

Conversation

ShadowySpirits
Copy link
Member

fix #6123

drpmma
drpmma previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #6124 (cfaa1a7) into develop (7049527) will increase coverage by 0.02%.
The diff coverage is 53.84%.

@@              Coverage Diff              @@
##             develop    #6124      +/-   ##
=============================================
+ Coverage      43.24%   43.26%   +0.02%     
- Complexity      8845     8860      +15     
=============================================
  Files           1094     1094              
  Lines          77137    77146       +9     
  Branches       10057    10060       +3     
=============================================
+ Hits           33355    33381      +26     
+ Misses         39613    39607       -6     
+ Partials        4169     4158      -11
Impacted Files Coverage Δ
...q/tieredstore/provider/posix/PosixFileSegment.java 60.17% <0.00%> (ø)
.../tieredstore/container/TieredContainerManager.java 46.80% <33.33%> (+0.48%) ⬆️
...ocketmq/tieredstore/container/TieredFileQueue.java 75.35% <100.00%> (+0.17%) ⬆️
...che/rocketmq/tieredstore/util/TieredStoreUtil.java 68.25% <100.00%> (+1.04%) ⬆️
...he/rocketmq/controller/impl/DLedgerController.java 66.49% <0.00%> (-2.62%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 71.87% <0.00%> (-2.09%) ⬇️
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 77.08% <0.00%> (-1.39%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.00% <0.00%> (-0.28%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.15% <0.00%> (-0.10%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 44.52% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShadowySpirits ShadowySpirits force-pushed the fix_flaky_test branch 2 times, most recently from 74fe17e to cfaa1a7 Compare February 20, 2023 13:58
@RongtongJin RongtongJin merged commit 4cc3311 into apache:develop Feb 21, 2023
mxsm pushed a commit to mxsm/rocketmq that referenced this pull request Feb 23, 2023
@ShadowySpirits @mxsm
[ISSUE apache#6123] Fix flaky test in tiered storage (apache#6124)
beba3fb 
* fix flaky test in tiered storage

* add debug logs

* destroy metadata store and container manager after TieredMessageStoreTest

* remove debug logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

@drpmma drpmma drpmma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky test in tiered storage
4 participants
@ShadowySpirits @codecov-commenter @drpmma @RongtongJin