Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test in tiered storage #6123

Closed
ShadowySpirits opened this issue Feb 20, 2023 · 2 comments · Fixed by #6124
Closed

Fix flaky test in tiered storage #6123

ShadowySpirits opened this issue Feb 20, 2023 · 2 comments · Fixed by #6124
Labels
module/test module/tiered-store

Comments

@ShadowySpirits
Copy link
Member

I have implemented a mock FileSegment called MemoryFileSegment for testing purposes. However, in some unit cases, it needs to disable the file size check. Currently, there is a static variable checkSize that controls this logic, which can lead to unexpected behavior when testing concurrently.
@ShadowySpirits ShadowySpirits mentioned this issue Feb 20, 2023
Merged
@francisoliverlee
Copy link
Member

可以讲解下什么情况下会导致 “ unexpected behavior”嘛？

@ShadowySpirits
Copy link
Member Author

我们的 CI 会并行执行单元测试，所以用静态变量控制是否检查文件大小会有并发问题

RongtongJin pushed a commit that referenced this issue Feb 21, 2023
@ShadowySpirits
[ISSUE #6123] Fix flaky test in tiered storage (#6124)
4cc3311 
* fix flaky test in tiered storage

* add debug logs

* destroy metadata store and container manager after TieredMessageStoreTest

* remove debug logs
mxsm pushed a commit to mxsm/rocketmq that referenced this issue Feb 23, 2023
@ShadowySpirits @mxsm
[ISSUE apache#6123] Fix flaky test in tiered storage (apache#6124)
beba3fb 
* fix flaky test in tiered storage

* add debug logs

* destroy metadata store and container manager after TieredMessageStoreTest

* remove debug logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/test module/tiered-store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6123] Fix flaky test in tiered storage ShadowySpirits/rocketmq
3 participants
@francisoliverlee @drpmma @ShadowySpirits