Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apache pulsar 2.5.1 release notes #6774

Merged
merged 13 commits into from
Apr 23, 2020

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Apr 20, 2020

Motivation

  • Update apache pulsar release 2.5.1 notes

Modifications

  • Update apache pulsar release 2.5.1 notes

* [build] Skip javadoc task for pulsar-client-kafka-compact modules [#5836](https://github.com/apache/pulsar/pull/5836)
* Add backlogSize in topicStats [#5914](https://github.com/apache/pulsar/pull/5914)
* Allow to enable/disable delayed delivery for messages on namespace [#5915](https://github.com/apache/pulsar/pull/5915)
* Upgrade Avro to 1.9.1 [#5938](https://github.com/apache/pulsar/pull/5938)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avro 1.9.1 enables the JSR310 datetimes by default, which might introduce some regression problems if users use generated source code by Avro compiler 1.8.x and contains datetimes fields. It's better to use Avro 1.9.x compiler to recompile.

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upgrade Avro from 1.8.x to 1.9.1 in this release and Avro 1.9.1 might introduce some regression problems. So we'd better declare this in the release note.

@tuteng
Copy link
Member Author

tuteng commented Apr 20, 2020

@codelipenghui @sijie PTAL

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fixes block in the release notes and also includes many fixes in the broker block, Pulsar schema block. How about the following pattern:

#### Fixes

##### Broker
##### Schema
##### Function

#### Enhancements

##### Broker
##### Schema
##### Function

And, I think we don't need to include all changes in the version 2.5.1, we just need to Point out some important changes. If users want to get all the change lists, they can find it in Github. So some test improvement, java doc fixes can be removed in the release notes.

The title of some pull requests sometimes is inaccurate, so it's better to double-check and give an accurate name in the release notes.

Sorry about I only reviewed part of it yesterday since I worry about miss import messages about upgrade Avro to 1.9.1.

Please check the comments, thanks.

* Bump netty version to 4.1.45.Final [#6424](https://github.com/apache/pulsar/pull/6424)
* Support BouncyCastle FIPS provider [#6588](https://github.com/apache/pulsar/pull/6588)
* Improve Key_Shared subscription message dispatching performance. [#6647](https://github.com/apache/pulsar/pull/6647)
* Add Joda time logical type conversion. [#6704](https://github.com/apache/pulsar/pull/6704)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add Joda time logical type conversion. [#6704](https://github.com/apache/pulsar/pull/6704)
* Add JSR310 logical type conversion. [#6704](https://github.com/apache/pulsar/pull/6704)


#### Fixes

* [Broker] Fixed unit test issue in BrokerServiceTest.java [#6006](https://github.com/apache/pulsar/pull/6006)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we need to include test fixes in the release notes?

* [Broker] Remove problematic semicolon from conf [#6303](https://github.com/apache/pulsar/pull/6303)
* [Zookeeper] Fixed casting in ZooKeeperCache.getDataIfPresent() [#6313](https://github.com/apache/pulsar/pull/6313)
* [Broker] Fixed broker to specify a list of bookie groups [#6349](https://github.com/apache/pulsar/pull/6349)
* Fixed Amend the default value of `supportedNamespaceBundleSplitAlgorithms` [#6374](https://github.com/apache/pulsar/pull/6374)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is fixes problems that #6241 introduced, so we can remove it from the release notes.

* Fixed the max backoff configuration for lookups [#6444](https://github.com/apache/pulsar/pull/6444)
* Pin the netty-transport-native-epoll to avoid conflicts [#6194](https://github.com/apache/pulsar/pull/6194)
* Fix java doc for key shared policy. [#6341](https://github.com/apache/pulsar/pull/6341)
* Seek to the first one >= timestamp [#6393](https://github.com/apache/pulsar/pull/6393)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks can't get key information of this fix, could you please check the PR and refine it.

#### Fixes

* [Broker] Fixed unit test issue in BrokerServiceTest.java [#6006](https://github.com/apache/pulsar/pull/6006)
* [Broker] Fixed NPE occur when get partitioned topic stats [#6060](https://github.com/apache/pulsar/pull/6060)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Broker] Fixed NPE occur when get partitioned topic stats [#6060](https://github.com/apache/pulsar/pull/6060)
* [Broker] Fixed NPE occurs when getting partitioned topic stats [#6060](https://github.com/apache/pulsar/pull/6060)

* [Pulsar Admin] allow tenant admin to manage subscription permission [#6122](https://github.com/apache/pulsar/pull/6122)
* [Broker] Output resource usage rate to log on broker [#6152](https://github.com/apache/pulsar/pull/6152)
* [Broker] Introduce maxMessagePublishBufferSizeInMB configuration to avoid broker OOM [#6178](https://github.com/apache/pulsar/pull/6178)
* Create managed ledger path on local zookeeper when create partitions [#6189](https://github.com/apache/pulsar/pull/6189)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is fixes problems that #5572 introduced, so we don't need to contain this one in the release notes.


* [Schema] Fixed get schema version in HttpLookupService. [#6193](https://github.com/apache/pulsar/pull/6193)
* [Schema] Independent schema is set for each consumer generated by topic [#6356](https://github.com/apache/pulsar/pull/6356)
* [Schema] Fixed wrong avro schema [#6406](https://github.com/apache/pulsar/pull/6406)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a meaningful name for this fix. You can pick some key sentences in the description of this PR. Sometimes the title of the PR did not express key messages.

* [Schema] Fixed get schema version in HttpLookupService. [#6193](https://github.com/apache/pulsar/pull/6193)
* [Schema] Independent schema is set for each consumer generated by topic [#6356](https://github.com/apache/pulsar/pull/6356)
* [Schema] Fixed wrong avro schema [#6406](https://github.com/apache/pulsar/pull/6406)
* [Schema] Fixed avro schema decode error in functions [#6662](https://github.com/apache/pulsar/pull/6662)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the above comment.

* [Schema] Independent schema is set for each consumer generated by topic [#6356](https://github.com/apache/pulsar/pull/6356)
* [Schema] Fixed wrong avro schema [#6406](https://github.com/apache/pulsar/pull/6406)
* [Schema] Fixed avro schema decode error in functions [#6662](https://github.com/apache/pulsar/pull/6662)
* [Schema] Fixed send get raw schema request [#6650](https://github.com/apache/pulsar/pull/6650)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Schema] Fixed send get raw schema request [#6650](https://github.com/apache/pulsar/pull/6650)
* [Schema] Fixed channel write error handling for send get raw schema request [#6650](https://github.com/apache/pulsar/pull/6650)

#### Pulsar Websocket
* [Websocket] Fixed Websocket doesn't set the correct cluster data [#6102](https://github.com/apache/pulsar/pull/6102)

#### Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to rename it to Deployments?

@tuteng
Copy link
Member Author

tuteng commented Apr 21, 2020

@codelipenghui Thanks for your comment, I have fixed, PTAL

@tuteng tuteng merged commit 0961f50 into apache:master Apr 23, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
### Motivation

* Update apache pulsar release 2.5.1 notes 

### Modifications

* Update apache pulsar release 2.5.1 notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants