Fix create consumer on partitioned topic while disable topic auto creation. #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wolfstudy if this PR can complete before cut 2.4.2, please considering include it, thanks. |
sijie
requested changes
Nov 6, 2019
There was a problem hiding this comment.
I don't think that is the right fix for this problem. The purpose of disabling topic auto-creation is to prevent consumers and producers creating topics.
I think the correct fix should be improving the pulsar-admin tool to create and delete partitions when creating or updating a partitioned topic.
|
run integration tests |
|
run java8 tests |
|
@codelipenghui l will change the |
|
@wolfstudy Thanks |
|
run java8 tests |
1 similar comment
|
run java8 tests |
|
run java8 tests |
3 similar comments
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
@sijie Please help review this PR again |
sijie
requested changes
Nov 20, 2019
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Outdated
Show resolved
Hide resolved
|
@codelipenghui are you going to include this fix in 2.5.0 or shall we move it to 2.5.1 or 2.6.0? |
|
it can move to 2.5.1 if 2.5.0 branch will start cut soon.
Sijie Guo <[email protected]>于2019年11月26日 周二04:57写道：
… @codelipenghui <https://github.com/codelipenghui> are you going to
include this fix in 2.5.0 or shall we move it to 2.5.1 or 2.6.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5572?email_source=notifications&email_token=ADACIBNEFVHYYSH7LBLXYSLQVQ35BA5CNFSM4JJSNE2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFDYW6Q#issuecomment-558336890>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADACIBNF3KJK4F5B2MUDI3DQVQ35BANCNFSM4JJSNE2A>
.
|
|
@sijie I have addressed your comments, PTAL. |
sijie
approved these changes
Dec 24, 2019
|
run java8 tests |
|
run java8 tests |
|
run integration tests |
1 similar comment
|
run integration tests |
jiazhai
pushed a commit
that referenced
this pull request
Feb 17, 2020
…ation. (#5572) ### Motivation Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation. ### Modifications By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use `create-missed-partitions` to repair. If users already have a partitioned topic without created partitions, can also use `create-missed-partitions` to repair. (cherry picked from commit 602f1c2)
|
done the cherry-pick to branch-2.5 |
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
…ation. (#5572) ### Motivation Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation. ### Modifications By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use `create-missed-partitions` to repair. If users already have a partitioned topic without created partitions, can also use `create-missed-partitions` to repair. (cherry picked from commit 602f1c2)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
…ation. (apache#5572) ### Motivation Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation. ### Modifications By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use `create-missed-partitions` to repair. If users already have a partitioned topic without created partitions, can also use `create-missed-partitions` to repair. (cherry picked from commit 602f1c2)
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jun 30, 2020
…ation. (apache#5572) Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation. By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use `create-missed-partitions` to repair. If users already have a partitioned topic without created partitions, can also use `create-missed-partitions` to repair.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ation. (apache#5572) ### Motivation Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation. ### Modifications By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use `create-missed-partitions` to repair. If users already have a partitioned topic without created partitions, can also use `create-missed-partitions` to repair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5565
Motivation
Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation.
Modifications
By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use
create-missed-partitionsto repair.If users already have a partitioned topic without created partitions, can also use
create-missed-partitionsto repair.Verifying this change
Add new unit tests for this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation