Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6619: WebSocket Topic URL Parser is Incorrect #6630

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Issue #6619: WebSocket Topic URL Parser is Incorrect #6630

merged 4 commits into from
Apr 2, 2020

Conversation

315157973
Copy link
Contributor

fix #6619

@315157973 315157973 closed this Mar 28, 2020
@315157973 315157973 reopened this Mar 28, 2020
@tschmidt64
Copy link

I think this still fails with topic names with multiple slashes on the check on line 172

@315157973
Copy link
Contributor Author

if (!expression) {
throw new IllegalArgumentException(String.valueOf(errorMessage));
}

Exceptions will thrown only if the size is less than 8

The 48 lines of the unit test include scenarios with multiple slashes

@codelipenghui codelipenghui added this to the 2.6.0 milestone Mar 29, 2020
@sijie sijie changed the title fix #6619 Issue #6619: WebSocket Topic URL Parser is Incorrect Mar 30, 2020
@jiazhai jiazhai merged commit 11eb86c into apache:master Apr 2, 2020
@sijie sijie mentioned this pull request May 20, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@315157973 @huangdx0726
Issue apache#6619: WebSocket Topic URL Parser is Incorrect (apache#6630)
e10615d 
fix apache#6619

* delete useless code

* fix apache#6619

* add license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@jiazhai jiazhai jiazhai approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@sijie sijie Awaiting requested review from sijie

Assignees

@315157973 315157973

Labels
area/websocket
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

WebSocket Topic URL Parser is Incorrect
4 participants
@315157973 @tschmidt64 @jiazhai @codelipenghui