WebSocket Topic URL Parser is Incorrect

[tschmidt64]

Describe the bug
The code in the web socket interface does not parse topic names correctly. I will limit my example to a consumer but similar issues apply to readers and producers.
From the code (line numbers are for reference, they do not match the actual code)

   1  String uri = request.getRequestURI();
   2  List<String> parts = Splitter.on("/").splitToList(uri);
   3
   4  // V1 Format must be like :
   5  // /ws/producer/persistent/my-property/my-cluster/my-ns/my-topic
   6  // or
   7  // /ws/consumer/persistent/my-property/my-cluster/my-ns/my-topic/my-subscription
   8  // or
   9  // /ws/reader/persistent/my-property/my-cluster/my-ns/my-topic
  10
  11  // V2 Format must be like :
  12  // /ws/v2/producer/persistent/my-property/my-ns/my-topic
  13  // or
  14  // /ws/v2/consumer/persistent/my-property/my-ns/my-topic/my-subscription
  15  // or
  16  // /ws/v2/reader/persistent/my-property/my-ns/my-topic
  17
  18  checkArgument(parts.size() >= 8, "Invalid topic name format");
  19  checkArgument(parts.get(1).equals("ws"));
  20
  21  final boolean isV2Format = parts.get(2).equals("v2");
  22  final int domainIndex = isV2Format ? 4 : 3;
  23  checkArgument(parts.get(domainIndex).equals("persistent") ||
  24          parts.get(domainIndex).equals("non-persistent"));
  25
  26
  27  final String domain = parts.get(domainIndex);
  28  final NamespaceName namespace = isV2Format ? NamespaceName.get(parts.get(5), parts.get(6)) :
  29          NamespaceName.get( parts.get(4), parts.get(5), parts.get(6));
  30  final String name = parts.get(7);
  31
  32  return TopicName.get(domain, namespace, name);
  33

To Reproduce
As an breaking example, take the v2 web socket topic URL:

/ws/v2/consumer/persistent/my-tenant/my-ns/some/topic/with/slashes/my-sub

In the code above, the following assignments would be made

  27  final String domain = parts.get(4)

which translates to

  27  final String domain = "persistent"  // this seems good

And then:

 28  final NamespaceName namespace = NamespaceName.get(parts.get(5), parts.get(6))

translates to:

 28  final NamespaceName namespace = NamespaceName.get("my-tenant", "my-ns") // this seems good

But then,

  30  final String name = parts.get(7);

translates to

  30  final String name = "some"; // THIS IS ONLY THE FIRST PART OF THE TOPIC

Expected behavior
The topic name should have been parsed as "some/topic/with/slashes".
The code assumes that the topic will not have any slashes in it. But this assumption is incorrect. The documentation explicitly states that "topic names are freeform". The Java code even tests for this case.

Screenshots
N/a

Desktop (please complete the following information):
N/a

Additional context
N/a

[sijie]

The topic name should have been parsed as "some/topic/with/slashes"

I don't think we support "/" in the topic name. "/" should be prohibited.