Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop increase unacked messages for the consumer with Exclusive/Failover subscription mode. #6558

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

codelipenghui
Copy link
Contributor

Fixes #6552

Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

Verifying this change

A new unit test added.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui added the type/bug The PR fixed a bug or issue reported a bug label Mar 19, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone Mar 19, 2020
@codelipenghui codelipenghui self-assigned this Mar 19, 2020
@sijie sijie merged commit 2449696 into apache:master Mar 19, 2020
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
tuteng pushed a commit that referenced this pull request Apr 6, 2020
…over subscription mode. (#6558)

Fixes #6552

### Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
…over subscription mode. (#6558)

Fixes #6552

### Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.
(cherry picked from commit 2449696)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.
@codelipenghui codelipenghui deleted the issue_6552 branch December 28, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant ack messages on exclusive subscriptions with partioned topic
2 participants