Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative un-ack messages in consumer stats #5929

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix negative un-ack messages in consumer stats #5929

merged 1 commit into from
Jan 6, 2020

Conversation

codelipenghui
Copy link
Contributor

Fixes #5755

Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

Verifying this change

Added unit test

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Dec 24, 2019
@codelipenghui codelipenghui added area/broker component/stats type/bug The PR fixed a bug or issue reported a bug labels Dec 24, 2019
@codelipenghui
Copy link
Contributor Author

run cpp tests

@codelipenghui
Copy link
Contributor Author

rerun cpp tests

@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests

@sijie sijie added this to the 2.6.0 milestone Jan 6, 2020
@sijie sijie merged commit 9d94860 into apache:master Jan 6, 2020
@sijie sijie modified the milestones: 2.6.0, 2.5.1 Jan 6, 2020
@sijie sijie modified the milestones: 2.5.1, 2.6.0 Jan 22, 2020
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Feb 23, 2020
@codelipenghui @tuteng
Fix negative un-ack messages in consumer stats (apache#5929)
3aa47bc 
Fixes apache#5755

### Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

### Verifying this change

Added unit test
@ilyam8 ilyam8 mentioned this pull request Mar 8, 2020
Closed
@sijie sijie mentioned this pull request Mar 8, 2020
Closed
@codelipenghui codelipenghui mentioned this pull request Mar 19, 2020
Merged
sijie pushed a commit that referenced this pull request Mar 19, 2020
@codelipenghui
Don't increment unacked messages for the consumer with Exclusive/Fail…
2449696 
…over subscription mode. (#6558)

Fixes #6552

### Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
@codelipenghui @tuteng
Fix negative un-ack messages in consumer stats (apache#5929)
63a66d0 
Fixes apache#5755

### Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

### Verifying this change

Added unit test

(cherry picked from commit 9d94860)
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
@codelipenghui @tuteng
Don't increment unacked messages for the consumer with Exclusive/Fail…
bf14a08 
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
tuteng pushed a commit that referenced this pull request Apr 6, 2020
@codelipenghui @tuteng
Don't increment unacked messages for the consumer with Exclusive/Fail…
a458fce 
…over subscription mode. (#6558)

Fixes #6552

### Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
@codelipenghui @tuteng
Fix negative un-ack messages in consumer stats (#5929)
e413d41 
Fixes #5755

### Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

### Verifying this change

Added unit test

(cherry picked from commit 9d94860)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
@codelipenghui @tuteng
Don't increment unacked messages for the consumer with Exclusive/Fail…
7bf3d6b 
…over subscription mode. (#6558)

Fixes #6552

### Motivation

#6552 is introduced by #5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.

(cherry picked from commit 2449696)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
@codelipenghui @jiazhai
Fix negative un-ack messages in consumer stats (apache#5929)
a014919 
Fixes apache#5755

### Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

### Verifying this change

Added unit test
(cherry picked from commit 9d94860)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
@codelipenghui @jiazhai
Don't increment unacked messages for the consumer with Exclusive/Fail…
eb68db8 
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.
(cherry picked from commit 2449696)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@codelipenghui @huangdx0726
Fix negative un-ack messages in consumer stats (apache#5929)
36d177f 
Fixes apache#5755

### Motivation

Fix negative un-ack messages in consumer stats while set maxUnackedMessagesPerConsumer=0

### Verifying this change

Added unit test
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@codelipenghui @huangdx0726
Don't increment unacked messages for the consumer with Exclusive/Fail…
95af7cc 
…over subscription mode. (apache#6558)

Fixes apache#6552

### Motivation

apache#6552 is introduced by apache#5929, so this PR stop increase unacked messages for the consumer with Exclusive/Failover subscription mode.
@codelipenghui codelipenghui deleted the issue-5755 branch May 19, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jiazhai jiazhai Awaiting requested review from jiazhai

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@codelipenghui codelipenghui

Labels
area/broker release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

UnAckedMessages admin information not correct
2 participants
@codelipenghui @sijie