Skip to content

[fix][sec] Eliminate commons-collections dependency #25024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 5 commits into from
Nov 27, 2025
Merged

[fix][sec] Eliminate commons-collections dependency #25024

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35dea66
Exclude commons-collections transitive dependency from commons-beanutils
lhotari Nov 27, 2025
3ce811c
Replace commons-collections usage in tests
lhotari Nov 27, 2025
fe960bb
Remove commons-collections from shaded jars
lhotari Nov 27, 2025
0220e6c
Exclude commons-collections from stream-storage-java-client dependency
lhotari Nov 27, 2025
18d53f9
Upgrade hadoop version to 3.4.2 which eliminates commons-collections
lhotari Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion distribution/server/src/assemble/LICENSE.bin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ The Apache Software License, Version 2.0
- commons-codec-commons-codec-1.20.0.jar
- commons-io-commons-io-2.21.0.jar
- commons-logging-commons-logging-1.3.5.jar
- commons-collections-commons-collections-3.2.2.jar
- org.apache.commons-commons-collections4-4.5.0.jar
- org.apache.commons-commons-compress-1.28.0.jar
- org.apache.commons-commons-configuration2-2.12.0.jar
Expand Down
1 change: 0 additions & 1 deletion distribution/shell/src/assemble/LICENSE.bin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ The Apache Software License, Version 2.0
- commons-text-1.14.0.jar
- commons-compress-1.28.0.jar
- commons-beanutils-1.11.0.jar
- commons-collections-3.2.2.jar
- commons-configuration2-2.12.0.jar
* Netty
- netty-buffer-4.1.128.Final.jar
Expand Down
2 changes: 1 addition & 1 deletion managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
import org.apache.bookkeeper.mledger.proto.MLDataFormats.PositionInfo;
import org.apache.bookkeeper.mledger.util.ManagedLedgerUtils;
import org.apache.bookkeeper.test.MockedBookKeeperTestCase;
import org.apache.commons.collections.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.lang3.mutable.MutableBoolean;
import org.apache.pulsar.common.api.proto.CommandSubscribe;
import org.apache.pulsar.common.api.proto.IntRange;
Expand Down
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,10 @@ flexible messaging model and an intuitive client API.</description>
<groupId>io.grpc</groupId>
<artifactId>grpc-netty</artifactId>
</exclusion>
<exclusion>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand Down Expand Up @@ -1744,6 +1748,12 @@ flexible messaging model and an intuitive client API.</description>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>${commons-beanutils.version}</version>
<exclusions>
<exclusion>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down
1 change: 0 additions & 1 deletion pulsar-client-admin-shaded/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.grpc:*</include>
<include>io.netty.incubator:*</include>
Expand Down
1 change: 0 additions & 1 deletion pulsar-client-all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.grpc:*</include>
<include>io.netty.incubator:*</include>
Expand Down
1 change: 0 additions & 1 deletion pulsar-client-shaded/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.netty.incubator:*</include>
<include>io.netty:*</include>
Expand Down
Loading