-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][sec] Eliminate commons-collections dependency #25024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 5 commits into
apache:master
from
lhotari:lh-eliminate-commons-collections
Nov 27, 2025
Merged
[fix][sec] Eliminate commons-collections dependency #25024
lhotari
merged 5 commits into
apache:master
from
lhotari:lh-eliminate-commons-collections
Nov 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Nov 27, 2025
15 tasks
Technoboy-
approved these changes
Nov 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25024 +/- ##
=============================================
+ Coverage 38.44% 74.31% +35.87%
- Complexity 13235 34065 +20830
=============================================
Files 1863 1920 +57
Lines 146149 150313 +4164
Branches 16972 17459 +487
=============================================
+ Hits 56183 111711 +55528
+ Misses 82305 29682 -52623
- Partials 7661 8920 +1259
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
added a commit
that referenced
this pull request
Nov 27, 2025
(cherry picked from commit 081b448)
lhotari
added a commit
that referenced
this pull request
Nov 27, 2025
(cherry picked from commit 081b448)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.9
release/4.1.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
commons-collections is consider vulnerable in Sonatype. Issue is https://issues.apache.org/jira/browse/COLLECTIONS-701 . This problem is fixed in commons-collections4.
commons-collections gets pulled in to Pulsar from BookKeeper dependencies where it's an optional dependency of commons-beanutils ("The main commons-beanutils.jar has an optional dependency on Commons Collections" source).
It's also a dependency of org.apache.bookkeeper:stream-storage-java-client where it gets pulled in as a transitive dependency of hadoop-common. hadoop-common version 3.4.2 has replaced commons-collections with commons-collections4 to address the vulnerability.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete