Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIP][broker]PIP-162: Enable system topic by default. #15619

Merged
merged 10 commits into from
May 23, 2022

Conversation

Technoboy-
Copy link
Contributor

Fixes #15333

Motivation

In PIP-39, we have introduced namespace event to support topic level policy. This feature was released in Pulsar 2.6.

Then PIP-92, we support topic policy to replicate across clusters and release in Pulsar 2.10.

And with version iteration, the corresponding topic policy CLI and functions are mature and stable, but users need to enable system topic to support these features. So it's better to enable system topic by default.

Documentation

  • doc
    (Your PR contains doc changes)

@Technoboy- Technoboy- self-assigned this May 16, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone May 16, 2022
@Technoboy- Technoboy- added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/broker type/PIP labels May 16, 2022
@codelipenghui codelipenghui added release/important-notice The changes which are important should be mentioned in the release note release/note-required labels May 16, 2022
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- changed the title [PIP][broker] PIP-162: Enable system topic by default. [PIP][broker][Don't Merge] PIP-162: Enable system topic by default. May 20, 2022
@Technoboy- Technoboy- changed the title [PIP][broker][Don't Merge] PIP-162: Enable system topic by default. [PIP][broker]PIP-162: Enable system topic by default. May 21, 2022
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I found some tests must disable the system topic and topic level policies, I'm not sure if there are break changes or if the test requires disabling topic level policies.

@Technoboy-
Copy link
Contributor Author

Great work! I found some tests must disable the system topic and topic level policies, I'm not sure if there are break changes or if the test requires disabling topic level policies.

Because the old behavior is disable the system topic. so we need to disable it explicitly so that some test could pass. Otherwise like metrics maybe affect by the system topic.

@Technoboy- Technoboy- deleted the enable-system-topic branch August 10, 2022 05:50
AlvaroStream added a commit to AlvaroStream/pulsar-site that referenced this pull request Jun 28, 2023
Not valid from 2.6.0 

Thanks @gaoran10

> We introduce topic-level policies from 2.6.0, refer to apache/pulsar#4955, but I think we support retention policies at the topic level from 2.7.0, refer to apache/pulsar#7747.

>Make the default value of the configuration topicLevelPoliciesEnabled as true from 2.11.0, refer to apache/pulsar#15619.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/important-notice The changes which are important should be mentioned in the release note type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIP-162: Enable system topic by default
6 participants