-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP][broker]PIP-162: Enable system topic by default. #15619
Conversation
/pulsarbot run-failure-checks |
969d173
to
96f4117
Compare
887ad60
to
c3e7b66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I found some tests must disable the system topic and topic level policies, I'm not sure if there are break changes or if the test requires disabling topic level policies.
Because the old behavior is disable the system topic. so we need to disable it explicitly so that some test could pass. Otherwise like metrics maybe affect by the system topic. |
Not valid from 2.6.0 Thanks @gaoran10 > We introduce topic-level policies from 2.6.0, refer to apache/pulsar#4955, but I think we support retention policies at the topic level from 2.7.0, refer to apache/pulsar#7747. >Make the default value of the configuration topicLevelPoliciesEnabled as true from 2.11.0, refer to apache/pulsar#15619.
Fixes #15333
Motivation
In PIP-39, we have introduced namespace event to support topic level policy. This feature was released in Pulsar 2.6.
Then PIP-92, we support topic policy to replicate across clusters and release in Pulsar 2.10.
And with version iteration, the corresponding topic policy CLI and functions are mature and stable, but users need to enable system topic to support these features. So it's better to enable system topic by default.
Documentation
doc
(Your PR contains doc changes)