[fix][doc] Misleading tip about retention, not mentioned topics policies. #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information about topic retention policies
|
@gaoran10 Could you please review this PR from a technical perspective? Thank you! |
gaoran10
reviewed
Jun 28, 2023
| @@ -1073,7 +1073,7 @@ Pulsar has two features, however, that enable you to override this default behav | |||
|
|
|||
| :::tip | |||
|
|
|||
| All message retention and expiry are managed at the [namespace](#namespaces) level. For a how-to, see the [Message retention and expiry](cookbooks-retention-expiry.md) cookbook. | |||
| All message retention and expiry are managed at the [namespace](#namespaces) level or at topic level from Pulsar `2.6.0` activating `topicLevelPoliciesEnabled=true` at broker.conf. Since `2.11` that default value is `true`. For a how-to, see the [Message retention and expiry](cookbooks-retention-expiry.md) cookbook. | |||
There was a problem hiding this comment.
We introduce topic-level policies from 2.6.0, refer to apache/pulsar#4955, but I think we support retention policies at the topic level from 2.7.0, refer to apache/pulsar#7747.
Make the default value of the configuration topicLevelPoliciesEnabled as true from 2.11.0, refer to apache/pulsar#15619.
Not valid from 2.6.0 Thanks @gaoran10 > We introduce topic-level policies from 2.6.0, refer to apache/pulsar#4955, but I think we support retention policies at the topic level from 2.7.0, refer to apache/pulsar#7747. >Make the default value of the configuration topicLevelPoliciesEnabled as true from 2.11.0, refer to apache/pulsar#15619.
gaoran10
approved these changes
Jun 29, 2023
Anonymitaet
reviewed
Jun 29, 2023
Co-authored-by: Anonymitaet <[email protected]>
Anonymitaet
approved these changes
Jun 29, 2023
hangc0276
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information about topic retention policies on the tip.
It forgets to mention that there are actions that can be performed at
topiclevel for retention and mislead that it can only be done at namespace leveldocdoc-requireddoc-not-neededdoc-complete