Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SomeTimes messages may be lost, those message has be add to ledger but were invisible for all consumers #12221

Closed
baomingyu opened this issue Sep 28, 2021 · 0 comments · Fixed by #12223
Closed

SomeTimes messages may be lost, those message has be add to ledger but were invisible for all consumers #12221

baomingyu opened this issue Sep 28, 2021 · 0 comments · Fixed by #12223
Assignees
@baomingyu
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@baomingyu
Copy link
Contributor

Describe the bug
Some messages has add to ledger 2207340 were lost!
image
image
image

To Reproduce
image
@baomingyu baomingyu added the type/bug The PR fixed a bug or issue reported a bug label Sep 28, 2021
@sijie sijie mentioned this issue Sep 28, 2021
Closed
@baomingyu baomingyu mentioned this issue Sep 28, 2021
Merged
codelipenghui pushed a commit that referenced this issue Sep 30, 2021
@baomingyu
Fix lost message issues 12221 (#12223)
eb9d9d4 
Fixes #12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: #12221 

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.
codelipenghui pushed a commit that referenced this issue Oct 6, 2021
@baomingyu @codelipenghui
Fix lost message issues 12221 (#12223)
e3c8386 
Fixes #12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: #12221 

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.

(cherry picked from commit eb9d9d4)
nicoloboschi pushed a commit to datastax/pulsar that referenced this issue Oct 27, 2021
@baomingyu @nicoloboschi
Fix lost message issues 12221 (apache#12223)
18a4ae3 
Fixes apache#12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: apache#12221

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.

(cherry picked from commit eb9d9d4)
(cherry picked from commit e3c8386)
@Technoboy- Technoboy- mentioned this issue Mar 11, 2022
Merged
1 task
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this issue Mar 16, 2022
@baomingyu @Technoboy-
Fix lost message issues 12221 (apache#12223)
20e924b 
Fixes apache#12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: apache#12221 

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.
@Technoboy- Technoboy- mentioned this issue Mar 16, 2022
Merged
1 task
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this issue Mar 18, 2022
@baomingyu @ciaocloud
Fix lost message issues 12221 (apache#12223)
9677277 
Fixes apache#12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: apache#12221 

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.
Shawyeok pushed a commit to Shawyeok/pulsar that referenced this issue Sep 6, 2022
@baomingyu @Shawyeok
Fix lost message issues 12221 (apache#12223) (eb9d9d4)
d4a16d3 
Fixes apache#12221

*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*

Master Issue: apache#12221

### Motivation
There  are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.

 So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one  time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baomingyu baomingyu

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix lost message issues 12221 baomingyu/pulsar
1 participant
@baomingyu