Enforce mypy for CLI #3305
Merged
Enforce mypy for CLI #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyCanCode
requested review from
HonahX,
eric-maynard and
flyrain
and removed request for
flyrain
flyrain
reviewed
Dec 22, 2025
| TARGET_NAME = "The name of the target entity (e.g., table name, namespace name)." | ||
| TARGET_NAME = ( | ||
| "The name of the target entity (e.g., table name, namespace name)." | ||
| ) |
Contributor
There was a problem hiding this comment.
Curious why we add parenthesis here, while removing them for HIVE_WAREHOUSE
Contributor
Author
There was a problem hiding this comment.
This was due to lint where the max characters per line exceed (not done by me implicitly by via our pre-commit hook). This was not done earlier due to code refactor and we were not pointing check to the new location.
flyrain
previously approved these changes
Dec 22, 2025
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
LGTM. Thanks @MonkeyCanCode ! I'm not a Python expert, cc @HonahX.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
previously approved these changes
Dec 29, 2025
Contributor
Author
Contributor
Author
dimas-b
approved these changes
Jan 2, 2026
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
obelix74
pushed a commit
to obelix74/polaris
that referenced
this pull request
Jan 6, 2026
Reverts changes from 'Enforce mypy for CLI (apache#3305)' which were accidentally included in this branch. These formatting/linting changes are unrelated to the metrics reporting feature.
evindj
pushed a commit
to evindj/polaris
that referenced
this pull request
Jan 26, 2026
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Feb 11, 2026
* Disable renovate bot for openapi generator cli (apache#3306) * Fix openapi-generator-cli version in build system * Fix openapi-generator-cli version in build system * Build: Ensure reproducible .properties files (apache#3089) This is a safety net in case Properties are generated anywhere during the build. * Generate release vote e-mail as Github Step Summary (apache#3150) * Improve error handling in quickstart setup script (apache#3288) Add error detection and validation to API calls in the quickstart docker-compose setup with clear error messages for easier debugging. * (doc): Fix tools doc and add tool doc for mcp server (apache#3311) * chore(deps): update actions/stale digest to a21a081 (apache#3326) * Add cancel release candidate workflow (apache#3321) This commit fixes apache#3080 * fix(deps): update quarkus platform and group to v3.30.5 (apache#3329) * chore(deps): update actions/checkout digest to 8e8c483 (apache#3319) * fix(deps): update dependency org.agrona:agrona to v2.4.0 (apache#3333) * (feat): Helm: add priority class name support for helm (apache#3310) * Add priority class name support for helm * Update changelog * Update default port for metrics from 8282 to 8182 (apache#3335) Corrects the default metrics port from 8282 to 8182 and clarifies the available metrics endpoints in the documentation. * fix(deps): update dependency software.amazon.awssdk:bom to v2.40.16 (apache#3336) * Add KMS options to catalogs create CLI (apache#3330) * Add Polaris blog about KMS (apache#3331) * Add Polaris blog about KMS Following up on apache#2802 * Use mainstream PostgreSQLContainer (apache#3345) Migrate from the deprecated PostgreSQLContainer class to the mainstream one as suggested by javadoc. * fix(deps): update dependency org.apache.iceberg:iceberg-bom to v1.10.1 (apache#3317) * Enforce mypy for CLI (apache#3305) * fix(deps): update dependency software.amazon.awssdk:bom to v2.41.1 (apache#3351) * Last merged commit e75eb4b --------- Co-authored-by: Yong Zheng <yongzheng0809@gmail.com> Co-authored-by: Pierre Laporte <pierre@pingtimeout.fr> Co-authored-by: Tamas Mate <50709850+tmater@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: rishii-19-works <rishipandey1912@gmail.com> Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces mypy for CLI code base (#3280). The current workflow was apply mypy to intergration_test only which doesn't make much sense. Also, due to the recent refactor of python cli, the lint was a bit off due to change of code base path. Thus, this got addressed in this PR as well.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)