Move more inner classes to top-level classes #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
eric-maynard
approved these changes
Mar 4, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
singhpk234
reviewed
Mar 4, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, thanks @flyrain !
Member
|
Overall it looks good to me. However, I would propose to wait a bit to see the outcome of the persistence work performed by @dennishuo and @snazy . |
Contributor
Author
Hi @jbonofre , this is a pure refactor without any logic change, as a followup of #1095. And #1097 has been merged, it won't be conflict with this one. |
collado-mike
approved these changes
Mar 4, 2025
HonahX
approved these changes
Mar 5, 2025
flyrain
force-pushed
the
more-dao-entity-refactor
branch
from
68f47c4 to
472f5bc
Compare
eric-maynard
approved these changes
Mar 11, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1095.