[NoSQL] Make TransactionalPersistence an interface #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `TransactionalPersistence` an interface and introduces `AbstractTransactionalPersistence` having the code that was in `TransactionalPersistence`.
snazy
requested review from
adutra,
ashvina,
dennishuo,
dimas-b and
eric-maynard
as code owners
snazy
requested review from
MonkeyCanCode,
RussellSpitzer,
collado-mike,
ebyhr,
flyrain,
jackye1995,
jbonofre,
takidau and
vvcephei
as code owners
Member
Member
Author
|
I don't know. But I'd like to prevent friction for the NoSQL work. |
Member
|
Yes. Sure. Just wondering. |
dimas-b
approved these changes
Mar 3, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
Merging quickly to enable faster Persistence API refactoring. If you notice any issues, let's fix in follow-up PRs. |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
gh-yzou
pushed a commit
to gh-yzou/polaris
that referenced
this pull request
Mar 6, 2025
This change makes `TransactionalPersistence` an interface and introduces `AbstractTransactionalPersistence` having the code that was in `TransactionalPersistence`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
TransactionalPersistencean interface and introducesAbstractTransactionalPersistencehaving the code that was inTransactionalPersistence.