Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE & NOTICE #6944

Merged
merged 1 commit into from
May 24, 2021
Merged

Update LICENSE & NOTICE #6944

merged 1 commit into from
May 24, 2021

Conversation

snleee
Copy link
Contributor

@snleee snleee commented May 19, 2021

The major code change in the UI(#5684) removed all the bundled
javascript/css files. This change removed bunch of copied js/css files
but the pr did not correctly address the license.

This PR is the effort for cleaning up licenses.

  1. Cleaned up LICENSE, LICENSE-binary
  2. Cleaned up licenses/, licenses-binary/
  3. Cleaned up NOTICE-binary

The major code change in the UI(apache#5684) removed all the bundled
javascript/css files. This change removed bunch of copied js/css files
but the pr did not correctly address the license.

This PR is the effort for cleaning up licenses.

1. Cleaned up LICENSE, LICENSE-binary
2. Cleaned up licenses/, licenses-binary/
3. Cleaned up NOTICE-binary
@snleee
Copy link
Contributor Author

snleee commented May 19, 2021

#6785

@snleee
Copy link
Contributor Author

snleee commented May 19, 2021

@felixcheung @olamy @kishoreg

Pinot mentors, can you review the license change above? Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #6944 (9082a02) into master (9becc57) will increase coverage by 0.01%.
The diff coverage is 46.96%.

❗ Current head 9082a02 differs from pull request most recent head 71db3be. Consider uploading reports for the commit 71db3be to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6944      +/-   ##
============================================
+ Coverage     73.41%   73.43%   +0.01%     
  Complexity       12       12              
============================================
  Files          1431     1432       +1     
  Lines         70689    70854     +165     
  Branches      10232    10258      +26     
============================================
+ Hits          51897    52031     +134     
- Misses        15344    15362      +18     
- Partials       3448     3461      +13     
Flag Coverage Δ Complexity Δ
integration 43.03% <8.83%> (-0.04%) 7.00 <0.00> (ø)
unittests 65.37% <45.30%> (-0.07%) 12.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oller/api/resources/PinotTableRestletResource.java 56.41% <0.00%> (-3.05%) 0.00 <0.00> (ø)
...ntroller/helix/core/PinotHelixResourceManager.java 62.47% <0.00%> (-0.20%) 0.00 <0.00> (ø)
...ot/controller/util/ConsumingSegmentInfoReader.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...manager/realtime/HLRealtimeSegmentDataManager.java 83.10% <ø> (ø) 0.00 <0.00> (ø)
...manager/realtime/LLRealtimeSegmentDataManager.java 73.06% <ø> (-0.43%) 0.00 <0.00> (ø)
...a/manager/realtime/RealtimeSegmentDataManager.java 100.00% <ø> (+42.85%) 0.00 <0.00> (ø)
...ator/transform/function/BaseTransformFunction.java 39.42% <ø> (+0.52%) 0.00 <0.00> (ø)
...org/apache/pinot/spi/config/table/TableStatus.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/org/apache/pinot/spi/utils/CommonConstants.java 29.82% <0.00%> (-1.66%) 0.00 <0.00> (ø)
...ator/transform/function/CastTransformFunction.java 65.82% <70.24%> (+5.82%) 0.00 <0.00> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9becc57...71db3be. Read the comment docs.

@snleee snleee merged commit 8878df5 into apache:master May 24, 2021
@snleee snleee deleted the update-license branch May 24, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants