-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster Manager UI & Query Console UI revamp #5684
Conversation
A couple suggestions:
|
@mayankshriv this is the first cut. lets get this in and we can add more functionality in the subsequent PR |
|
@shahsank3t This looks great! I tried this locally and it worked seamlessly. I was also able to bring it up by running quickstart from IDE (though it requires one to build the project from the command line) query editor has some minor issues. The cursor keeps jumping/moving to the end as I type. This happens when you are trying to edit an existing query. typing new query works fine |
@kishoreg Yes agree, my comment is more towards the general direction of where we should take it. Also, I take it that cluster manager UI will replace Swagger? Would be good to start a doc/issue to capture all the features we would want cluster manager to have and address them in future PRs. |
@shahsank3t I see that you are deleting a lot of js files. I think that the license file needs to be updated accordingly. Can you fix
|
@kishoreg @mayankshriv - Addressed this suggestion and added the Tables details page. Yes, currently showing the JSON object and later on can add incremental updates to it. |
The major code change in the UI(apache#5684) removed all the bundled javascript/css files. This change removed bunch of copied js/css files but the pr did not correctly address the license. This PR is the effort for cleaning up licenses. 1. Cleaned up LICENSE, LICENSE-binary 2. Cleaned up licenses/, licenses-binary/ 3. Cleaned up NOTICE-binary
The major code change in the UI(#5684) removed all the bundled javascript/css files. This change removed bunch of copied js/css files but the pr did not correctly address the license. This PR is the effort for cleaning up licenses. 1. Cleaned up LICENSE, LICENSE-binary 2. Cleaned up licenses/, licenses-binary/ 3. Cleaned up NOTICE-binary
Description
Complete revamp of existing UI containing Cluster Manager & Query Console.
This PR is against Cluster Manager #5649
Cluster Manager UI contains a listing of Tenants & Table within, Broker, Controller, Server, Cluster Configuration
Query Console UI is a complete revamp with Material UI styling.
This PR removes all the existing pinot-controller's static & webapp and gets replaced with an app developed using React + TypeScript + Material UI and few other 3rd Party libraries and built using webpack.
Also added a plugin in pinot-controller pom file to build the frontend using node & npm.
Open items that can be added as part of another PR: