-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LICENSE and NOTICE files #3722
Conversation
Followed Apache Spark's approach for handling LICENSE, NOTICE. apache/spark@f825847 - Checked licenses for all libraries that we bundle - Checked licenses for all js/css files that we bundle - Removed dependencies of category X libraries (#3718)
After removing category X dependency and removing "pinot-perf" from distribution package, we are bundling The extensive list is present at the following spreadsheet https://docs.google.com/spreadsheets/d/1lMEEvrA8SqHe0Yy0yC2Nd-nN5lg5sPaNwihrj_--y8Q/edit?usp=sharing |
@felixcheung @olamy Can you check this when you find the time? |
Codecov Report
@@ Coverage Diff @@
## master #3722 +/- ##
============================================
+ Coverage 67.18% 67.21% +0.02%
Complexity 4 4
============================================
Files 1027 1027
Lines 50830 50830
Branches 7093 7093
============================================
+ Hits 34150 34165 +15
+ Misses 14336 14324 -12
+ Partials 2344 2341 -3
Continue to review full report at Codecov.
|
Awesome! You make my OCD so satisfied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the binary releases may contain binary code from third parties. This is very much true for Scala and Java, if binary release which includes all transitive binary dependencies
### Apache License 2
The Apache License 2 variants are typically easiest to deal with as they will not require you to modify LICENSE, nor add to license/. It's still good form to list the ALv2 dependencies in LICENSE for completeness, but optional.
some JS files copy in other JS files! Look out for Modernizr.
# One More Thing: JS and CSS in Binary Release
Now that you've got a handle on source licenses, recall that all the JS and CSS source code will *also* be part of the binary release. Copy that info from source to binary license files accordingly.
+100 for doing this. qq: why do we need to create a license file for each library? for e.g. args4j is distributed under MIT license. https://github.com/kohsuke/args4j. We can just list this library in the NOTICE file under MIT licenses section rt? |
@kishoreg In my understanding, we have 2 approaches.
@felixcheung Please correct me if I'm wrong. |
|
Great job on getting this done! It would be good to have the google doc linked either on the cwiki or the RTD(may be in the Developer Guide section). |
It seems that the pointer is needed for BSD, MIT licenses. The example above has the link pointer to the full license As long as we don't violate the license issue, I can go ahead for removing copied license files from |
(I think we exchange email on this, we might need to put MIT license under LICENSES/) |
@felixcheung The current pr includes the license with MIT and BSD under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have the build change to include LICENSE-binary in the binary release tarball?
pinot-controller/src/main/resources/*/css/lib/codemirror* | ||
pinot-controller/src/main/resources/*/css/lib/foundation* | ||
pinot-controller/src/main/resources/*/css/lib/normalize.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I'm not too familiar with this - are we saying these js css files are checked into the git repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those files are the part of the git repo (they are used for some UI components. e.g. pinot query console). After checking in this, I will file a separate PR for handling the build to include LICENSE-binary for the binary release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, LGTM except for the release process comment
Followed Apache Spark's approach for handling LICENSE, NOTICE.
apache/spark@f825847