-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies from libraries under category X licenses. #3718
Conversation
37dc74a
to
cff0bd4
Compare
Followed Apache Spark's approach for handling LICENSE, NOTICE. apache/spark@f825847 - Checked licenses for all libraries that we bundle - Checked licenses for all js/css files that we bundle - Removed dependencies of category X libraries (#3718)
is there replacement for "pinot-perf" module? |
@felixcheung |
@snleee sure - keep in mind ASF release is primarily a source code release. sounds like pinot-perf (source code) is still there and so long as it doesn't contain source code in a different license. it will help to have an README in the source to point out pinot-perf module is pulling "jmh-core" based on GPL 2 license, and instruction to build pinot-perf |
f407cc9
to
7f5d1cf
Compare
* Update LICENSE and NOTICE files Followed Apache Spark's approach for handling LICENSE, NOTICE. apache/spark@f825847 - Checked licenses for all libraries that we bundle - Checked licenses for all js/css files that we bundle - Removed dependencies of category X libraries (#3718) * Add LICENSE-binary, NOTICE-binary to differentiate source code and binary release
Codecov Report
@@ Coverage Diff @@
## master #3718 +/- ##
============================================
+ Coverage 67.01% 67.29% +0.28%
Complexity 4 4
============================================
Files 1027 1027
Lines 50798 50796 -2
Branches 7091 7091
============================================
+ Hits 34041 34182 +141
+ Misses 14423 14284 -139
+ Partials 2334 2330 -4
Continue to review full report at Codecov.
|
@felixcheung As you mentioned, |
For an ASF project, its distribution should not contain any of work under category X license. After running "mvn project-info-reports:dependencies", three libraries are under category X libraries for our distribution package. This PR resolves this issue. 1. Removed "pinot-perf" module from distribution package because pinot-perf module is pulling "jmh-core" based on GPL 2 license, which is a category X. 2. Fixed pom file to generate *.sh files for benchmarks in "pinot-perf" and added on documentation on how to build and run. 3. Bumped up the version of org.testng from 6.0.1 to 6.11 because the old version was pulling in "org.beanshell:bsh:2.0b4", which is also based on LGPL license. The newer version no longer pulls beanshell. 4. Bumped up the swagger version from 1.5.10 to 1.5.16. The old version was pulling "org.reflections:reflections:0.9.10", which pulls "com.google.code.findbugs:annotations", which was based on LGPL. For the list of category X licenses, please refer https://www.apache.org/legal/resolved.html
7f5d1cf
to
7a96b5c
Compare
For an ASF project, its distribution should not contain any of work under
category X license. After running "mvn project-info-reports:dependencies",
three libraries are under category X libraries for our distribution package.
This PR resolves this issue.
module is pulling "jmh-core" based on GPL 2 license, which is a category X.
version was pulling in "org.beanshell:bsh:2.0b4", which is also based on
LGPL license. The newer version no longer pulls beanshell.
pulling "org.reflections:reflections:0.9.10", which pulls
"com.google.code.findbugs:annotations", which was based on LGPL.
For the list of category X licenses, please refer
https://www.apache.org/legal/resolved.html