=str Add IterableSource. #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Aug 22, 2023
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/SourceSpec.scala
Outdated
Show resolved
Hide resolved
pjfanning
approved these changes
Aug 22, 2023
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm - but I'd prefer if some other reviewers also had a look before we merge
nvollmar
reviewed
Aug 22, 2023
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/SourceSpec.scala
Show resolved
Hide resolved
nvollmar
reviewed
Aug 22, 2023
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/IterableSource.scala
Outdated
Show resolved
Hide resolved
nvollmar
reviewed
Aug 22, 2023
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/IterableSource.scala
Show resolved
Hide resolved
Signed-off-by: He-Pin <[email protected]>
nvollmar
reviewed
Aug 22, 2023
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/IterableSource.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was akka/akka-core#31372
This introduce a dedicated IterableSource, which can be later used for performance optimization. And also obey the supervisionStrategy now.