=str Add IterableSource. #31372
Merged
=str Add IterableSource. #31372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
flattenSource2
branch
5 times, most recently
from
939df37 to
387904e
Compare
He-Pin
force-pushed
the
flattenSource2
branch
2 times, most recently
from
5929665 to
57bb0e7
Compare
Contributor
|
Can you explain a bit more what the problem this PR is trying to solve is? Did you observe performance problems with the composed operator? |
Contributor
Author
|
@johanandren I was trying to solve refs: #21462 |
Contributor
|
I see, so it is to be able to determine and optimize iterable sources in for example Akka HTTP. @jrudolph is the new stage here useful for that? |
patriknw
reviewed
Sep 1, 2022
akka-stream/src/main/scala/akka/stream/impl/fusing/GraphStages.scala
Outdated
Show resolved
Hide resolved
akka-stream/src/main/scala/akka/stream/impl/fusing/GraphStages.scala
Outdated
Show resolved
Hide resolved
akka-stream/src/main/scala/akka/stream/impl/fusing/GraphStages.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
flattenSource2
branch
5 times, most recently
from
063ee82 to
1fb5bcf
Compare
He-Pin
force-pushed
the
flattenSource2
branch
2 times, most recently
from
86586a6 to
690513f
Compare
He-Pin
force-pushed
the
flattenSource2
branch
from
690513f to
57f66e4
Compare
He-Pin
force-pushed
the
flattenSource2
branch
from
57f66e4 to
122a879
Compare
junglechange
reviewed
Jun 1, 2023
| if (isAvailable(out)) { | ||
| push(out, currentIterator.next()) | ||
| } | ||
| if (!currentIterator.hasNext) { |
There was a problem hiding this comment.
why call hasNext here,is it ok not to to call here?
Contributor
There was a problem hiding this comment.
If it just pushed the last element it can immediately complete the stage after that instead of waiting for next pull to make that decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
single(iterable).mapConcat(ConstantFun.scalaIdentityFunction).withAttributes(DefaultAttributes.iterableSource)is too longThe current
Source.fromIterableis implemented with asingleandStatefulMapConcat, when the upstream'sSingleSourceis completed, the internal state ofStatefulMapConcatis discarded and completed, and therestartingDeciderwill not make it purpose becauseisClosed(in)is true.I think this can enable further optimization in the FlattenMerge, but PR will change the current behavior of
Source.fromIterable.More optimization can be done in
FlatMapMerge